Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: using invoker command instead of JS glue code #989

Merged
merged 2 commits into from
Oct 11, 2024
Merged

refactor: using invoker command instead of JS glue code #989

merged 2 commits into from
Oct 11, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Oct 8, 2024 •
edited
Loading

Resolves #922

  • Removed some JavaScript glue code for opening the dialog
  • Introduced command- and commandfor-HTML-attributes and invokers-polyfill as a polyfill

@mfranzke mfranzke added this to the Guidelines v2 milestone Oct 8, 2024
@mfranzke mfranzke self-assigned this Oct 8, 2024
@mfranzke mfranzke linked an issue Oct 8, 2024 that may be closed by this pull request
Introduce invoker commands instead of JS glue code #922
Closed
@mfranzke mfranzke removed their assignment Oct 8, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation patterns labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/922-introduce-invoker-commands-instead-of-js-glue-code

@mfranzke mfranzke enabled auto-merge (squash) October 8, 2024 16:32
@mfranzke mfranzke merged commit e4af366 into main Oct 11, 2024
12 checks passed
@mfranzke mfranzke deleted the 922-introduce-invoker-commands-instead-of-js-glue-code branch October 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annsch annsch annsch approved these changes

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees

@annsch annsch

Labels
documentation Improvements or additions to documentation improvement patterns
Projects
None yet
Milestone
Guidelines v2
Development

Successfully merging this pull request may close these issues.

Introduce invoker commands instead of JS glue code
2 participants
@mfranzke @annsch