Skip to content

Commit

Permalink
refactor: testing (#14)
Browse files Browse the repository at this point in the history
* refactor: disabled some html validation aspects

either because of example related or specific usage

* refactor: we don't need to declare this role

as it's set implicitly, compare to e.g. developer.mozilla.org/en-US/docs/Web/HTML/Element/footer

* refactor: we don't need to declare this role

as it's set implicitly, compare to e.g. developer.mozilla.org/en-US/docs/Web/HTML/Element/main

* refactor: disabled the correct code line

* refactor: disabled html validation aspect

* refactor: consistent quotes

* refactor: consistent quotes

* refactor: in case we don't have a description, we won't need the aria-describedby attribute

* chore: providing another default

* refactor: set a default for the buttontype

* refactor: restructured the sample page

to reflect a correct headline structure

* refactor: ignore those headline structures on HTML validation

as they are too hard to influence in sample pages

* refactor: we don't need to declare this role

as it's set implicitly, compare to e.g. developer.mozilla.org/en-US/docs/Web/HTML/Element/nav

* refactor: ignore those headline structures on HTML validation

as they are too hard to influence in sample pages

* refactor: ignore this headline structures on HTML validation

as a headline of type 2 is perfectly fine in this new context

* refactor: there shouldn't be more than one main landmark elements

* refactor: ignore those headline structures on HTML validation

as they are too hard to influence in sample pages

* refactor: details tag nesting in p not allowed

Element <details> is not permitted as content in <p>

* refactor: corrected that attributes naming

* refactor: ignore this headline structures on HTML validation

as they are too hard to influence in sample pages

* refactor: adapted the HTML validation rules to our needs

* refactor: optimized the test and lint scripts

reordered, renamed and added npx

* chore: removed leftover

* refactor: optimized list of test urls for accessibility

* refactor: optimized test scripts

and added new dependency for running server and tests in parallel

* refactor: disabling stylelint rules for specific code parts

* refactor: stylelint feedback

* refactor: stylelint feedback

* refactor: html validate feedback

* test: we don't want to test for self-closing tags

* feat: suggesting html validate as well as VS Code extension

* refactor(test): using the smaller markup-only files for HTML testing

* chore: regenerated package-lock.json

* chore: prettier optimization

* refactor: running prettier for linting

* chore: we need the SCSS function here

* chore: we need to provide different ID values here
  • Loading branch information
mfranzke authored Nov 16, 2022
1 parent cbc3aae commit 9616a23
Show file tree
Hide file tree
Showing 40 changed files with 727 additions and 542 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/01-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ jobs:
- name: 🔄 Init Cache
uses: ./.github/actions/npm-cache

- name: ⚡ Run Lint
run: npm run lint

- name: ⚡ Run Test
run: npm run test

Expand Down
8 changes: 5 additions & 3 deletions .htmlvalidate.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
{
"extends": ["html-validate:document", "html-validate:recommended"],

"rules": {
"void-style": ["warn", { "style": "selfclosing" }],
"require-sri": ["error", { "target": "crossorigin" }]
"require-sri": ["error", { "target": "crossorigin" }],
"no-trailing-whitespace": ["off"],
"doctype-style": ["off"],
"element-name": ["error", { "whitelist": ["dialog"] }],
"missing-doctype": ["off"]
}
}
217 changes: 25 additions & 192 deletions .pa11yci

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ dependencyGraph.json
source/js/*.min.js*
package-lock.json
*.hbs
out/
6 changes: 5 additions & 1 deletion .stylelintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"stylelint-config-prettier"
],
"rules": {
"order/properties-alphabetical-order": null,
"scss/operator-no-newline-after": null,
"declaration-empty-line-before": null,
"selector-no-qualifying-type": null,
"selector-class-pattern": null,
"scss/dollar-variable-pattern": null,
Expand All @@ -14,6 +17,7 @@
"declaration-property-value-disallowed-list": null,
"scss/percent-placeholder-pattern": null,
"scss/at-mixin-pattern": null,
"order/properties-alphabetical-order": null
"order/properties-alphabetical-order": null,
"scss/at-import-partial-extension": null
}
}
3 changes: 2 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"recommendations": [
"editorconfig.editorconfig",
"henrynguyen5-vsc.vsc-nvm",
"streetsidesoftware.code-spell-checker"
"streetsidesoftware.code-spell-checker",
"html-validate.vscode-html-validate"
]
}
Loading

0 comments on commit 9616a23

Please sign in to comment.