refactor: enabled overwriting icons set via icon SCSS mixin (#510)

refactor: enabled overwriting programmatically set icons via icon SCSS mixin #509
db-ui · Jul 13, 2023 · 1c8186d · 1c8186d
1 parent 1bc1b21
commit 1c8186d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/source/_patterns/00-base/icons/_icons.helpers.scss b/source/_patterns/00-base/icons/_icons.helpers.scss
@@ -6,6 +6,11 @@
 	$position: "before",
 	$partial: false
 ) {
+	// We're setting this on the parent tag, so that it could get overwritten via data-icon=*
+	@if $glyph != "" {
+		--icon-glyph: "#{$glyph}";
+	}
+
 	&::#{$position} {
 		--icon-font-family: "#{"icons-" + $size + "-" + $style}",
 			"missing-icons" !important;
@@ -25,9 +30,6 @@
 			);
 		}
 
-		@if $glyph != "" {
-			--icon-glyph: "#{$glyph}";
-		}
 		@if $partial {
 			content: var(--icon-glyph);
 			display: inline-block;