Skip to content

Commit

Permalink
fix: svg icon issues with fill (#267)
Browse files Browse the repository at this point in the history
* refactor: simplified icon filled declarations

* refactor: simplified the logos fill styles as well

* docs: adapted instructions to README

* chore: added another necessary replaced color
  • Loading branch information
mfranzke authored Feb 27, 2023
1 parent 6e2bd5a commit 5a48e1f
Show file tree
Hide file tree
Showing 1,191 changed files with 1,197 additions and 1,193 deletions.
6 changes: 5 additions & 1 deletion assets/icons/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ We're getting these icons by the [DB Design System colleagues](https://dbsw.shar

- Minifications with [`ImageOptim`](https://imageoptim.com/mac)
- Adding some contents within the SVGs (these assets might get exported correctly in the future)
- CSS variables (replace `fill="#282D37"` by `fill="#282D37" style="fill: currentColor;fill: var(--db-icon-color, currentColor)"`)
- CSS variables
- replace `fill="#282D37"` by `fill="var(--db-icon-color, currentColor)"`
- replace `fill="#55b9e6"` by `fill="var(--db-icon-color, #55b9e6)"`
- replace `fill="#EC0016"` by `fill="var(--db-icon-pulse-color, #EC0016)"`
- replace `fill="#78be14"` by `fill="var(--db-icon-pulse-color, #78be14)"`
- `id`-Attribute (generic `icon` id within all SVG files)
- Afterwards the JSON files within the `source/_patterns/icons` path might need to get updated
2 changes: 1 addition & 1 deletion assets/icons/functional/images/action/db_ic_account_20.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/functional/images/action/db_ic_account_24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/functional/images/action/db_ic_account_32.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/functional/images/action/db_ic_add_16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/functional/images/action/db_ic_add_20.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/functional/images/action/db_ic_add_24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/functional/images/action/db_ic_add_32.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 5a48e1f

Please sign in to comment.