-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add re-frame to cljs-oss/canary #478
Comments
I don't understand what's proposed in this issue yet but, for the record, I followed the provided link and it looks as though reagent and re-frame were recently deleted from oss-canary. |
@mike-thompson-day8 it looks like re-frame had to be forked to support things like running the tests headlessly (switching chrome for phantomjs [although chrome can be run headless if you have chromedriver in the CI environment]), support for env vars to set the clojurescript version and config for running TravisCI tests. Suggestion is to upstream those changes to this repository, so they will always be up-to-date, instead of having to maintain a separate, forked version, where any fixes to this repository would have to be merged, and potential merge conflicts resolved. |
I think something with PhantomJS was causing issues with the latest generated JavaScript and evidently moving to something more modern (Puppeteer?) can resolve the issues. I tried futzing with it and, not being well versed in web-dev technologies, didn't make any progress. Ideally, yeah, if re-frame joined the Canary project, then re-frame team members would be notified for Canary build failures, be able to maintain things with respect to re-frame master, etc. (The |
The changes for this repository are done, now preparing an associated PR for cljs-oss/canary. |
@mfikes has already done the hard work of creating a canary config for https://github.com/cljs-oss/canary/tree/master. We should think about merging it in to this project, so we can run tests against the latest ClojureScript and detect any breaking changes well in advance.
@mike-thompson-day8 what do you think?
The text was updated successfully, but these errors were encountered: