Add function to remove unused media files #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Could you already have a look at this pull request? Anything I should fix/improve? |
@SteffenWolfFA-ERF : To accept a PR, it needs to pass all tests, some of which failed (see below). Do you want to try to fix them? You may run PS. Please be aware that you will also need to sync your fork and merge the changes that have happened in the master branch since May, when you submitted your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request at all. So please excuse if there are mistakes.
I put the function in openxml_document class, because it should be used by presentation and docx_part classes. The function gets executed during presentation -> remove_slide() and it should delete all media files, that aren't referenced in any xml.rels file.