Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cursor based pagination #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

accessd
Copy link

@accessd accessd commented Mar 14, 2017

Hi!
I think this feature suitable for this gem.
Solution based on Kaminari and works independently.

@accessd accessd force-pushed the cursor-base-pagination branch 2 times, most recently from 83ce774 to 435f26a Compare March 15, 2017 07:49
@zabolotnov87
Copy link
Contributor

👍

@accessd accessd force-pushed the cursor-base-pagination branch 5 times, most recently from 79c6f46 to 8376c1e Compare March 20, 2017 18:17
@accessd accessd force-pushed the cursor-base-pagination branch from 8376c1e to 2347a6d Compare March 22, 2017 09:13
@zabolotnov87
Copy link
Contributor

@davidcelis hi! Could you please review the PR?

@davidcelis
Copy link
Owner

Hey folks; I'm definitely thinking about this, but there's a lot of potential with this cursor based paginator. I'm weighing the removal of Kaminari and WillPaginate as possible dependencies, as cursor-based pagination works better than LIMIT/OFFSET. This could be a big breaking change for anybody already using the gem, though, so it'd be a major version update.

I'm just weighing my options as to whether this should be an additional paginator, or basically a rewrite of the gem. Thanks!

@accessd
Copy link
Author

accessd commented Mar 29, 2017

Hey! Just a idea: api-pagination with cursor based pagination, and api-pagination-adapters which supports Kaminari and WillPaginate. Or even api-pagination-kaminari, api-pagination-will-paginate

@davidcelis
Copy link
Owner

@accessd That's definitely another possibility, and it'd make it easier to support patches to the kaminari/will_paginate paginators instead of having to backport them to previous versions…

So far I think I like that idea the best. Let me ruminate on it a bit more for a day or two 😄

@bcthomas
Copy link

bcthomas commented Nov 4, 2017

very anxious to see this PR merged. Any updates?

@jvenezia
Copy link

Looks amazing! Any updates :) ?

@jvenezia
Copy link

jvenezia commented Jul 11, 2018

Hey @davidcelis did you have the time to think about this?
We ended up writing it ourselves, but I would have loved to use this gem feature instead.
For me it makes sense to have this along with the existing pagination.

@oyeanuj
Copy link

oyeanuj commented Feb 14, 2020

@jvenezia Could you share the library that you wrote since it feels like this library isn't active anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants