-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cursor based pagination #79
base: master
Are you sure you want to change the base?
Conversation
83ce774
to
435f26a
Compare
👍 |
79c6f46
to
8376c1e
Compare
8376c1e
to
2347a6d
Compare
@davidcelis hi! Could you please review the PR? |
Hey folks; I'm definitely thinking about this, but there's a lot of potential with this cursor based paginator. I'm weighing the removal of Kaminari and WillPaginate as possible dependencies, as cursor-based pagination works better than LIMIT/OFFSET. This could be a big breaking change for anybody already using the gem, though, so it'd be a major version update. I'm just weighing my options as to whether this should be an additional paginator, or basically a rewrite of the gem. Thanks! |
Hey! Just a idea: |
@accessd That's definitely another possibility, and it'd make it easier to support patches to the kaminari/will_paginate paginators instead of having to backport them to previous versions… So far I think I like that idea the best. Let me ruminate on it a bit more for a day or two 😄 |
very anxious to see this PR merged. Any updates? |
Looks amazing! Any updates :) ? |
Hey @davidcelis did you have the time to think about this? |
@jvenezia Could you share the library that you wrote since it feels like this library isn't active anymore? |
Hi!
I think this feature suitable for this gem.
Solution based on Kaminari and works independently.