Add Magick Save, Support ICO LOAD #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds ExportMagick(). libvips supports image encoding through ImageMagick, and formats such as BMP require ImageMagick for proper saving. (vips_magicksave)
Additionally, ICO image loading can now be handled with ImageMagick.
Added
func (r *ImageRef) ExportMagick(params *MagickExportParams) ([]byte, *ImageMetadata, error): Exports an image using ImageMagick.
MagickExportParams: Parameters for configuring ImageMagick-based export.
Modified
Previously, when saving GIFs, govips used magicksave if the libvips version was lower than 8.12. Therefore, this PR modified the GIF save logic accordingly to accommodate the changes in magick save options in this changes.