fix: bug fix on updating url

ckanext/doi/cli.py

@@ -94,8 +94,10 @@ def update_doi(package_ids):
         client = DataciteClient()
 
         same = client.check_for_update(record.identifier, xml_dict)
-        if True:
+        if not same:
             try:
+                url = xml_dict.get('alternateIdentifiers', [])[0].get('alternateIdentifier')
+                client.client.doi_post(record.identifier, url)
                 client.set_metadata(record.identifier, xml_dict)
                 click.secho(f'Updated "{title}"', fg='green')
             except DataCiteError as e:

ckanext/doi/lib/api.py

@@ -146,12 +146,9 @@ def set_metadata(self, doi, xml_dict):
 
         # check that the data is valid, this will raise a JSON schema exception if there are issues
         schema42.validator.validate(xml_dict)
-        url = xml_dict.get('alternateIdentifiers', [])[0].get('alternateIdentifier')
-
 
         xml_doc = schema42.tostring(xml_dict)
-        # update the URL the DOI points to
-        self.client.doi_post(doi, url)
+
         # create the metadata on datacite
         self.client.metadata_post(xml_doc)
 
@@ -225,5 +222,9 @@ def update_doi(self, package_id, pkg_dict=None):
             # update doi if metadata has changed
             same = self.check_for_update(doi.identifier, xml_dict)
             if not same:
+                url = xml_dict.get('alternateIdentifiers', [])[0].get('alternateIdentifier')
+                # update the url if it has changed
+                self.client.doi_post(doi.identifier, url)
+
                 # Not the same, so we want to update the metadata
                 self.set_metadata(doi.identifier, xml_dict)