Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#28 optionally enfore relationship type by test meta #32

Merged
merged 3 commits into from
May 5, 2023

Conversation

datnguye
Copy link
Owner

@datnguye datnguye commented May 4, 2023

resolves #28

Description

  • Cover relationship type by test meta config
  • Default to many-to-one if not specified

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #32 (18dee09) into main (3fe00f3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines          730       788   +58     
=========================================
+ Hits           730       788   +58     
Impacted Files Coverage Δ
dbterd/adapters/algos/meta.py 100.00% <100.00%> (ø)
dbterd/adapters/algos/test_relationship.py 100.00% <100.00%> (ø)
...rd/adapters/targets/dbml/dbml_test_relationship.py 100.00% <100.00%> (ø)
...pters/targets/mermaid/mermaid_test_relationship.py 100.00% <100.00%> (ø)
...ers/targets/plantuml/plantuml_test_relationship.py 100.00% <100.00%> (ø)
dbterd/constants.py 100.00% <100.00%> (ø)
...ests/unit/adapters/algos/test_test_relationship.py 100.00% <100.00%> (ø)
...apters/targets/dbml/test_dbml_test_relationship.py 100.00% <100.00%> (ø)
.../targets/mermaid/test_mermaid_test_relationship.py 100.00% <100.00%> (ø)
...argets/plantuml/test_plantuml_test_relationship.py 100.00% <100.00%> (ø)

@datnguye datnguye marked this pull request as ready for review May 5, 2023 04:15
@datnguye datnguye merged commit 0c1bea5 into main May 5, 2023
@datnguye datnguye deleted the feature/#28-optionally-enforce-rel-type branch May 5, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally enforce relationship types
1 participant