Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#20 improve selection #22

Merged
merged 10 commits into from
Apr 22, 2023
Merged

Feature/#20 improve selection #22

merged 10 commits into from
Apr 22, 2023

Conversation

datnguye
Copy link
Owner

@datnguye datnguye commented Apr 22, 2023

resolve #20

Description

  • Apply wildcard to selection criteria
  • Allow multiple -s and -ns
  • Cosmetic and Code refactor

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #22 (3505acf) into main (5d6ec65) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        31    +6     
  Lines          598       681   +83     
=========================================
+ Hits           598       681   +83     
Impacted Files Coverage Δ
dbterd/adapters/algos/meta.py 100.00% <ø> (ø)
dbterd/adapters/factory.py 100.00% <ø> (ø)
dbterd/adapters/worker.py 100.00% <ø> (ø)
dbterd/cli/main.py 100.00% <ø> (ø)
dbterd/cli/params.py 100.00% <ø> (ø)
dbterd/helpers/file.py 100.00% <ø> (ø)
dbterd/adapters/algos/base.py 100.00% <100.00%> (ø)
dbterd/adapters/algos/filter.py 100.00% <100.00%> (ø)
dbterd/adapters/algos/test_relationship.py 100.00% <100.00%> (ø)
dbterd/adapters/base.py 100.00% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@datnguye datnguye marked this pull request as ready for review April 22, 2023 06:15
@datnguye datnguye merged commit 7ee2467 into main Apr 22, 2023
12 checks passed
@datnguye datnguye deleted the feature/#20-improve-selection branch April 22, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple sections using -s and -ns flags, or regex pattern
1 participant