Fix XStream Security Vulnerability in XML Deserialization #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses a critical security vulnerability (CVE-2021-21341 and similar) in our XStream usage that could allow remote code execution through XML deserialization attacks. The current implementation lacked proper security restrictions on the XStream instance, allowing deserialization of arbitrary classes. This vulnerability was also found in t-oster/VisiCut@3d6b930, corresponding to CVE-2021-39141 and fixed in this git commit. References: 1. https://nvd.nist.gov/vuln/detail/cve-2021-39141 2. t-oster/VisiCut@3d6b930
|
hi @baisui1981 thanks for merging my PR! I'm planning to submit this as a CVE, do let me know whether it's okay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a critical security vulnerability (CVE-2021-21341 and similar) in our XStream usage that could allow remote code execution through XML deserialization attacks. The current implementation lacked proper security restrictions on the XStream instance, allowing deserialization of arbitrary classes.
This vulnerability was also found in t-oster/VisiCut@3d6b930, corresponding to CVE-2021-39141 and fixed in this git commit.
References: