Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Challenge #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Code Challenge #35

wants to merge 3 commits into from

Conversation

dorukhac
Copy link

@dorukhac dorukhac commented Jul 13, 2024

Overview

This PR brings functionality to the Parserator page.

You can type in an address into the input bar and it will parse an us address and display its type,
parts, and tags.

It will also display any errors that may happen.

Closes #XXX

Demo

0b30c96011cf065dc1c6908f79cbc6e0

Notes

The unit testing for the error is somewhat simple, just checking for a 400 error.
The error response is quite lengthy so for the sake of brevity kept the error testing short.

I also updated the Dockerfile to use a non-deprecated link for Node, the old one wasnt working.

Testing Instructions

  • Clone the directory
  • If you are using a Windows machine, make sure the docker-entrypoint.sh is using LF for its end of line sequence.
  • In the directory use "docker compose build"
  • Then use "docker compose up"
  • go to localhost:8000 on your preferred browser
  • Input any US address you want to parse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant