Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add campaign contributions to person detail #421

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Conversation

derekeder
Copy link
Member

@derekeder derekeder commented Jun 4, 2024

Adds a searchable table of campaign contributions to each Alder on their detail page.

This PR includes:

  • adds table and section to Alder detail page
  • adds candidate_id from IL Board of Elections for each Alder
  • stores Alder metadata in a CSV and loads it in via a cached function in utils.py
  • updates ChicagoPerson model code to access new metadata
  • adds text and link to Illinois Sunshine page under Campaign Donations section
  • pins version of django-haystack[elasticsearch] to v3.2.1 to handle a recently introduced build error
  • removes opencivicdata 3.2 dependency. no longer needed as that feature has been merged in

Screenshot 2024-06-05 at 3 49 02 PM

Testing

  • visit several alder pages. confirm they have a new tab to click on for Campaign Donations
  • browse, search, filter the table to confirm the data looks right
  • Alders without a candidate id, like the Mayor, should not show that table

@derekeder derekeder temporarily deployed to chi-councilm-campaign-d-wkjzoe June 4, 2024 21:29 Inactive
@derekeder
Copy link
Member Author

gettin somewhere!

Screenshot 2024-06-04 at 4 27 40 PM

@derekeder
Copy link
Member Author

Created a Google Sheet with alder metadata that I can export https://docs.google.com/spreadsheets/d/1f2hbjnvkqD6QYjjPZ4yxBunLS9k7t2Y1cyCP9E9V4ns/edit#gid=0

@derekeder derekeder temporarily deployed to chi-councilm-campaign-d-dkpatn June 5, 2024 20:08 Inactive
@derekeder derekeder temporarily deployed to chi-councilm-campaign-d-psege7 June 5, 2024 20:12 Inactive
@derekeder derekeder temporarily deployed to chi-councilm-campaign-d-akddmh June 5, 2024 20:17 Inactive
@derekeder derekeder temporarily deployed to chi-councilm-campaign-d-t9pvrj June 5, 2024 20:39 Inactive
@derekeder derekeder marked this pull request as ready for review June 5, 2024 21:31
@derekeder derekeder requested a review from fgregg June 5, 2024 21:31
@derekeder derekeder temporarily deployed to chi-councilm-campaign-d-t9pvrj June 5, 2024 21:31 Inactive
Copy link
Member

@fgregg fgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should be handling this a management command instead of loading the file in each time, but it's an improvement of the status quo.

@derekeder derekeder merged commit 3b6a88b into main Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants