Switch to async for notebook client #26
Draft
+290
−125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The foundation of jupyter ydoc is built on top of pycrdt a thin wrapper of Yrs. Unfortunately that library is not thread safe. Therefore when implementing the logic for an agent reacting to document changes, we were facing lost of critical runtime error because the changes and the callback are not necessarily implemented in the same thread.
The best workaround while keeping Yrs is to move to an async approach to fake multi-threading. Hence this PR.