feat(ingest/dbt): fallback to schema from graph #13438
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
|
✅ Meticulous spotted 0 visual differences across 1261 screens tested: view results. Meticulous evaluated ~12 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 077f996. This comment will update as new commits are pushed. |
| # If we don't have a schema for this node from the dbt catalog | ||
| # and were unable to infer it (e.g. for sources), then we use | ||
| # the schema from the graph. | ||
| node.columns_setdefault(schema_fields) |
There was a problem hiding this comment.
We may have a debug log trace here and maybe a counter in the report.
There was a problem hiding this comment.
Regarding updates in the OperatorProcessor: I left comments on the stacked PR
datahub-cyborg
bot
added
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #13436