Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI to insert resource into local catalog #228

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Conversation

Pierlou
Copy link
Contributor

@Pierlou Pierlou commented Nov 28, 2024

This proved useful locally for me, to insert a new resource into my local catalog (or update an existing one), instead of having to do database shenaningans

Copy link
Contributor

@bolinocroustibat bolinocroustibat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite useful indeed, thanks!
LGTM, but should we write a test for this new command in tests/test_cli.py?

@Pierlou
Copy link
Contributor Author

Pierlou commented Dec 6, 2024

I don't like the "default" value in the CLI function, but it seemed to be the only way to make the test pass. We will fix this when #232 is treated

@bolinocroustibat
Copy link
Contributor

Don't forget the changelog!

@Pierlou Pierlou merged commit 72f8827 into main Dec 6, 2024
4 checks passed
@Pierlou Pierlou deleted the feat/cli-insert-resource branch December 6, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants