Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to force analysis even if resource has not changed #205

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

Pierlou
Copy link
Contributor

@Pierlou Pierlou commented Oct 28, 2024

We're missing this feature: forcing analysis on a resource, independently of whether its content has changed since last check.

Copy link
Contributor

@bolinocroustibat bolinocroustibat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few questions:
Is this related to the ability to manually check a URL even though the resource doens't exist in the DB? Should we also create a ticket about that to go with it (and it that case, it shouldn't update any resource status of course)

@bolinocroustibat
Copy link
Contributor

bolinocroustibat commented Oct 28, 2024

Would be nice to add a test about that, when resource has not changed but parameter force_analysis is passed as False, then another test with True.

@Pierlou
Copy link
Contributor Author

Pierlou commented Oct 28, 2024

Is this related to the ability to manually check a URL even though the resource doens't exist in the DB? Should we also create a ticket about that to go with it (and it that case, it shouldn't update any resource status of course)

Nope, completely different topic. I have created this issue, is that fine?

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have minor suggestions/questions :)

udata_hydra/cli.py Outdated Show resolved Hide resolved
udata_hydra/crawl/check_resources.py Outdated Show resolved Hide resolved
udata_hydra/routes/checks.py Outdated Show resolved Hide resolved
@bolinocroustibat
Copy link
Contributor

Is this related to the ability to manually check a URL even though the resource doens't exist in the DB? Should we also create a ticket about that to go with it (and it that case, it shouldn't update any resource status of course)

Nope, completely different topic. I have created this issue, is that fine?

Definitely, thank you

@bolinocroustibat bolinocroustibat merged commit 44660b7 into main Nov 6, 2024
4 checks passed
@bolinocroustibat bolinocroustibat deleted the feat/force-analysis branch November 6, 2024 16:54
bolinocroustibat added a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants