feat: Simplify build using java-locator #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using java-locator we no longer have to specify JAVA_HOME for a build, it can be done only at runtime(and preferably letting the Java application set it itself), this also resolves the various issues with jdk-8/11 and the varying file locations that have changed over the years, as it will search for the root java dir, which gives directly access to the headers, and only then searches for the libjvm recursively in directories within the root dir.
I've added the libjvm's path to the RPATH, for tests, this does not propagate to rlibs, so is only relevant for the test binary.