Upgrade to Datafusion 48 #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlymatthew
changed the title
friendlymatthew
force-pushed
the
friendlymatthew/df-latest
branch
from
2e461c3 to
ae09910
Compare
adriangb
reviewed
Jun 12, 2025
tests/main.rs
Outdated
Comment on lines
507
to
512
| return_type: &DataType::Utf8, | ||
| return_field: Arc::new(Field::new("ret_field", DataType::Utf8, false)), |
There was a problem hiding this comment.
Should we mark these as json?
There was a problem hiding this comment.
Hmm, what do you mean by marking as json? Do you mean marking the return_field as a json type? This test case is expecting json_get_str to return a ScalarValue::Utf8.
There was a problem hiding this comment.
datafusion-functions-json/src/common_union.rs
Line 162 in b9dfacd
adriangb
approved these changes
Jun 12, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 82.62% 82.62%
=======================================
Files 15 15
Lines 1180 1180
Branches 1180 1180
=======================================
Hits 975 975
Misses 144 144
Partials 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit accounts for breaking changes in Datafusion 48. See upgrading guide.
Here are the things that break: