Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify aggregation challenge solution #382

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Joe-Heffer-Shef
Copy link

Changes

  • Add a paragraph to explain the SQL query in the solution
  • Use full words for the column alias, rather than a single letter

- Explain the SQL query
- Use full words for the column alias, rather than a single letter
Copy link

github-actions bot commented Jan 10, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/sql-ecology-lesson/compare/md-outputs..md-outputs-PR-382

The following changes were observed in the rendered markdown documents:

 02-sql-aggregation.md | 9 +++++++--
 md5sum.txt            | 2 +-
 2 files changed, 8 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-01-24 13:04:32 +0000

@jd-foster
Copy link
Contributor

Thanks for the contribution - I've added some suggestions from review.

github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants