Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode 4 updated by replacing calls to raster and rgdal packages with calls to terra package. #387

Merged
merged 4 commits into from
Mar 18, 2023

Conversation

albhasan
Copy link
Contributor

@albhasan albhasan commented Mar 6, 2023

Episode 4 updated by replacing calls to raster and rgdal packages with calls to terra package.
#368 #363

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-387

The following changes were observed in the rendered markdown documents:

 03-raster-reproject-in-r.md                        | 365 +++++++++++----------
 04-raster-calculations-in-r.md                     | 354 +++++++++++---------
 chm_ov_SJER.tiff                                   | Bin 6656479 -> 6656567 bytes
 ...in-r-rendered-challenge-code-reprojection-1.png | Bin 232693 -> 210212 bytes
 ...ter-reproject-in-r-rendered-plot-DTM-hill-1.png | Bin 49855 -> 49505 bytes
 ...oject-in-r-rendered-plot-projected-raster-1.png | Bin 141502 -> 129256 bytes
 ...-calculations-in-r-rendered-chm-harv-hist-1.png | Bin 4668 -> 5196 bytes
 ...lations-in-r-rendered-chm-harv-hist-green-1.png | Bin 4286 -> 4743 bytes
 ...alculations-in-r-rendered-chm-harv-raster-1.png | Bin 28264 -> 28265 bytes
 ...tions-in-r-rendered-compare-chm-harv-sjer-1.png | Bin 4668 -> 5196 bytes
 ...tions-in-r-rendered-compare-chm-harv-sjer-2.png | Bin 4220 -> 4721 bytes
 ...er-calculations-in-r-rendered-create-hist-1.png | Bin 4668 -> 5196 bytes
 ...tions-in-r-rendered-sjer-chm-overlay-hist-1.png | Bin 4220 -> 4721 bytes
 md5sum.txt                                         |   4 +-
 14 files changed, 391 insertions(+), 332 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-03-18 16:17:52 +0000

github-actions bot pushed a commit that referenced this pull request Mar 6, 2023
@jsta
Copy link
Member

jsta commented Mar 10, 2023

This PR looks like it has changes to both episodes 3 and 4? Just checking to see if that's a mistake.

…ges with calls to terra package. datacarpentry#368 datacarpentry#363" because it was included by accident.
@albhasan
Copy link
Contributor Author

@jsta Yes, I made a mistake while branching episode 4, I'm sorry. I ran a git reverton the offending commit and pushed it again. I think that will fix it. Cheers!

github-actions bot pushed a commit that referenced this pull request Mar 18, 2023
@drakeasberry drakeasberry merged commit 8ffb88e into datacarpentry:main Mar 18, 2023
github-actions bot pushed a commit that referenced this pull request Mar 18, 2023
Auto-generated via {sandpaper}
Source  : 8ffb88e
Branch  : main
Author  : Drake Asberry <[email protected]>
Time    : 2023-03-18 16:20:53 +0000
Message : Merge pull request #387 from albhasan/m2022q1_e4

Episode 4 updated by replacing calls to raster and rgdal packages with calls to terra package.
github-actions bot pushed a commit that referenced this pull request Mar 18, 2023
Auto-generated via {sandpaper}
Source  : d4b1838
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-03-18 16:27:20 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 8ffb88e
Branch  : main
Author  : Drake Asberry <[email protected]>
Time    : 2023-03-18 16:20:53 +0000
Message : Merge pull request #387 from albhasan/m2022q1_e4

Episode 4 updated by replacing calls to raster and rgdal packages with calls to terra package.
zkamvar added a commit that referenced this pull request Mar 23, 2023
This addresses the accidental reversion that happened in
#387

see
carpentries/sandpaper#411 (comment)
for details
@zkamvar zkamvar mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants