Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson 1 updated by replacing calls to raster and rgdal packages #384

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

albhasan
Copy link
Contributor

Lesson 1 updated by replacing calls to raster and rgdal packages with calls to terra package.

#368 #363

@github-actions
Copy link

github-actions bot commented Feb 25, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-384

The following changes were observed in the rendered markdown documents:

 01-raster-structure.md                             | 387 +++++-----
 config.yaml (gone)                                 |  95 ---
 ...rendered-demonstrate-no-data-black-ggplot-1.png | Bin 119921 -> 122868 bytes
 ...cture-rendered-demonstrate-no-data-ggplot-1.png | Bin 166788 -> 171149 bytes
 ...raster-structure-rendered-unnamed-chunk-7-1.png | Bin 221085 -> 214918 bytes
 ...raster-structure-rendered-unnamed-chunk-9-1.png | Bin 109504 -> 109498 bytes
 ...integration-rendered-compare-data-extents-1.png | Bin 33244 -> 33202 bytes
 ...tion-rendered-repeat-compare-data-extents-1.png | Bin 33244 -> 33202 bytes
 md5sum.txt                                         |  50 +-
 renv.lock (gone)                                   | 810 ---------------------
 10 files changed, 235 insertions(+), 1107 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-03-06 15:11:37 +0000

github-actions bot pushed a commit that referenced this pull request Feb 25, 2023
github-actions bot pushed a commit that referenced this pull request Feb 26, 2023
@@ -53,11 +52,10 @@ data values as stored in a raster and how R handles these elements.

We will continue to work with the `dplyr` and `ggplot2` packages that were introduced
in the [Introduction to R for Geospatial Data](https://datacarpentry.org/r-intro-geospatial/) lesson. We will use two additional packages in this episode to work with raster data - the
`raster` and `rgdal` packages. Make sure that you have these packages loaded.
`raster` and `sf` packages. Make sure that you have these packages loaded.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this text specifying the raster package be replaced with terra?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I changed the text from raster to terra. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution on transitioning to terra. A few notes below on updating text content for learners to follow along with updated code will be very helpful:

Line 84 references GDAL() function that has now been removed and should be updated to reflect describe()
Line 151 references raster() and should be updated to reflect the forcing of dataframe creation
Lines 319-332 references raster() and nlayers()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reporting the typos. I fixed them.

github-actions bot pushed a commit that referenced this pull request Feb 27, 2023
github-actions bot pushed a commit that referenced this pull request Mar 6, 2023
@jsta
Copy link
Member

jsta commented Mar 6, 2023

Looks good to me. I say we go ahead and merge given that the lesson url is pinned to the 2023/2/6 snapshot. Anyone else have thoughts?

Only thing I'm on the fence about is the very long output of describe. Is there an easy way to shorten?

@albhasan
Copy link
Contributor Author

albhasan commented Mar 6, 2023

@jsta I agree with you regarding describe. We could try the meta argument to get the file metadata instead, but I guess we get the opposite problem instead; I mean, barely a line of metadata:

describe("data/NEON-DS-Airborne-Remote-Sensing/HARV/DSM/HARV_dsmCrop.tif", meta = TRUE)
> [1] "AREA_OR_POINT=Area"

@jsta jsta merged commit 2cc2f7b into datacarpentry:main Mar 10, 2023
@jsta
Copy link
Member

jsta commented Mar 10, 2023

Thanks for taking this on @albhasan!

github-actions bot pushed a commit that referenced this pull request Mar 10, 2023
Auto-generated via {sandpaper}
Source  : 2cc2f7b
Branch  : main
Author  : Jemma Stachelek <[email protected]>
Time    : 2023-03-10 20:11:21 +0000
Message : Merge pull request #384 from albhasan/m2022q1

Lesson 1 updated by replacing calls to raster and rgdal packages
github-actions bot pushed a commit that referenced this pull request Mar 10, 2023
Auto-generated via {sandpaper}
Source  : 60e6276
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-03-10 20:25:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 2cc2f7b
Branch  : main
Author  : Jemma Stachelek <[email protected]>
Time    : 2023-03-10 20:11:21 +0000
Message : Merge pull request #384 from albhasan/m2022q1

Lesson 1 updated by replacing calls to raster and rgdal packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants