-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lesson 1 updated by replacing calls to raster and rgdal packages #384
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-384 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-03-06 15:11:37 +0000 |
episodes/01-raster-structure.Rmd
Outdated
@@ -53,11 +52,10 @@ data values as stored in a raster and how R handles these elements. | |||
|
|||
We will continue to work with the `dplyr` and `ggplot2` packages that were introduced | |||
in the [Introduction to R for Geospatial Data](https://datacarpentry.org/r-intro-geospatial/) lesson. We will use two additional packages in this episode to work with raster data - the | |||
`raster` and `rgdal` packages. Make sure that you have these packages loaded. | |||
`raster` and `sf` packages. Make sure that you have these packages loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this text specifying the raster
package be replaced with terra
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I changed the text from raster
to terra
. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution on transitioning to terra. A few notes below on updating text content for learners to follow along with updated code will be very helpful:
Line 84 references GDAL() function that has now been removed and should be updated to reflect describe()
Line 151 references raster() and should be updated to reflect the forcing of dataframe creation
Lines 319-332 references raster() and nlayers()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reporting the typos. I fixed them.
Looks good to me. I say we go ahead and merge given that the lesson url is pinned to the 2023/2/6 snapshot. Anyone else have thoughts? Only thing I'm on the fence about is the very long output of |
@jsta I agree with you regarding
|
Thanks for taking this on @albhasan! |
Auto-generated via {sandpaper} Source : 2cc2f7b Branch : main Author : Jemma Stachelek <[email protected]> Time : 2023-03-10 20:11:21 +0000 Message : Merge pull request #384 from albhasan/m2022q1 Lesson 1 updated by replacing calls to raster and rgdal packages
Auto-generated via {sandpaper} Source : 60e6276 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-03-10 20:25:57 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 2cc2f7b Branch : main Author : Jemma Stachelek <[email protected]> Time : 2023-03-10 20:11:21 +0000 Message : Merge pull request #384 from albhasan/m2022q1 Lesson 1 updated by replacing calls to raster and rgdal packages
Lesson 1 updated by replacing calls to raster and rgdal packages with calls to terra package.
#368 #363