Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarifying language because magnitudes are stupid #213

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

abostroem
Copy link
Contributor

@abostroem abostroem commented Dec 30, 2023

Closes #199
Clarifies that lower on the y-axis means a larger magnitude value

Copy link

github-actions bot commented Dec 30, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/astronomy-python/compare/md-outputs..md-outputs-PR-213

The following changes were observed in the rendered markdown documents:

 07-photo.md | 2 +-
 md5sum.txt  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-30 01:20:38 +0000

github-actions bot pushed a commit that referenced this pull request Dec 30, 2023
@ErinBecker ErinBecker merged commit 0f9bef7 into datacarpentry:main Mar 8, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
Auto-generated via {sandpaper}
Source  : 0f9bef7
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-03-08 23:43:45 +0000
Message : Merge pull request #213 from abostroem/issue199-fainter

clarifying language because magnitudes are stupid
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
Auto-generated via {sandpaper}
Source  : e18cff2
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-08 23:44:36 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 0f9bef7
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-03-08 23:43:45 +0000
Message : Merge pull request #213 from abostroem/issue199-fainter

clarifying language because magnitudes are stupid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remark on y-axis value of fainter stars perhaps unclear
2 participants