Skip to content

Conversation

@sundarshankar89
Copy link
Collaborator

@sundarshankar89 sundarshankar89 commented Dec 11, 2025

Changes

What does this PR do?

Profiler Test Connection

databricks labs lakebridge test-profiler-connection

Relevant implementation details

Caveats/things to watch out for when reviewing:

Linked issues

Resolves #..

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs lakebridge ...
  • ... +add your own

Tests

  • manually tested
  • added unit tests
  • added integration tests

@sundarshankar89 sundarshankar89 self-assigned this Dec 11, 2025
@sundarshankar89 sundarshankar89 added feat/profiler Issues related to profilers feat/cli actions that are visible to the user labels Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 13.20755% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.37%. Comparing base (b26e72f) to head (8287803).

Files with missing lines Patch % Lines
...cks/labs/lakebridge/connections/synapse_helpers.py 10.41% 43 Missing ⚠️
src/databricks/labs/lakebridge/cli.py 14.58% 41 Missing ⚠️
...ks/labs/lakebridge/connections/database_manager.py 22.22% 7 Missing ⚠️
.../resources/assessments/synapse/common/connector.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2186      +/-   ##
==========================================
- Coverage   63.96%   63.37%   -0.59%     
==========================================
  Files         101      102       +1     
  Lines        8651     8752     +101     
  Branches      894      906      +12     
==========================================
+ Hits         5534     5547      +13     
- Misses       2947     3035      +88     
  Partials      170      170              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

✅ 56/56 passed, 4 flaky, 4m51s total

Flaky tests:

  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (23.478s)
  • 🤪 test_transpiles_informatica_to_sparksql (25.318s)
  • 🤪 test_transpile_teradata_sql (27.723s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (6.953s)

Running from acceptance #3305

@sundarshankar89 sundarshankar89 marked this pull request as ready for review December 30, 2025 10:03
@sundarshankar89 sundarshankar89 requested a review from a team as a code owner December 30, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat/cli actions that are visible to the user feat/profiler Issues related to profilers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants