Fix JDBC compliance of DatabricksStatement#setMaxRows(0) #901
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the JDBC interface contract of Statement#setMaxRows, a value of 0 must be interpreted as "no limit". The DEFAULT_RESULT_ROW_LIMIT seems to capture these semantics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the JDBC interface contract of
Statement#setMaxRows, a value of 0 must be interpreted as "no limit". Currently passing a value of 0 literally means 0 rows will be returned. Instead, theDEFAULT_RESULT_ROW_LIMITseems to capture the semantics of "no limit", if I'm reading the code correctly, so I used that in the PR.Testing
Tests have been added to check that setting max rows of 0 results in the
DEFAULT_RESULT_ROW_LIMITto be set.Additional Notes to the Reviewer