Open
Conversation
Author
|
I'm not sure my modification is actually what you want "hit_aggregator" to do. This was my attempt to ensure that the resulting consensus peak set is non-overlapping (currently I find that sometimes there is some overlap between peaks)... An alternative approach could be to apply "reduce" to the results from the original implementation at the end, instead of defining a disjoint set up front. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a modified version of the hit_aggregator() function that does the following:
(1) takes all peak regions from all narrowPeak files in the project and defines a set of k non-overlapping regions using GenomicRanges “reduce”
(2) assigns each observed peak across narrowPeak files to one of the k non-overlapping regions defined in (1)
(3) for each of the k non-overlapping regions, it finds which observed peak has the highest score
The function returns a list of k regions with peak boundaries based on the highest scoring peaks in step (3).