Skip to content

update hitaggregator function#211

Open
ccrobertson wants to merge 1 commit intodatabio:masterfrom
ccrobertson:hitaggregator
Open

update hitaggregator function#211
ccrobertson wants to merge 1 commit intodatabio:masterfrom
ccrobertson:hitaggregator

Conversation

@ccrobertson
Copy link

Here is a modified version of the hit_aggregator() function that does the following:

(1) takes all peak regions from all narrowPeak files in the project and defines a set of k non-overlapping regions using GenomicRanges “reduce”
(2) assigns each observed peak across narrowPeak files to one of the k non-overlapping regions defined in (1)
(3) for each of the k non-overlapping regions, it finds which observed peak has the highest score

The function returns a list of k regions with peak boundaries based on the highest scoring peaks in step (3).

@ccrobertson
Copy link
Author

I'm not sure my modification is actually what you want "hit_aggregator" to do. This was my attempt to ensure that the resulting consensus peak set is non-overlapping (currently I find that sometimes there is some overlap between peaks)... An alternative approach could be to apply "reduce" to the results from the original implementation at the end, instead of defining a disjoint set up front.

@nsheff nsheff requested a review from jpsmith5 July 7, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant