refactor(storage): refine recluster levels and log level IO - #20443
refactor(storage): refine recluster levels and log level IO#20443zhyass wants to merge 2 commits into
Conversation
Mix only levels 1-3 in aggressive mode and promote based on the highest level's share of logical block bytes. Share cluster-level log statistics for insert and recluster, exclude remained blocks from rewrite output, and trim redundant tests.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca9df16418
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
1,1,3 -> 3,1,3,3 -> 4, and1,2,3 -> 3. Preserve the executor's base-level-plus-one convention.fuse insert output,fuse recluster input, andfuse recluster outputlogs withtable_id,level,block_count,block_size, andfile_size. ShareClusterLevelLogStats; preserve per-block insert levels before segment reduction, and exclude unchanged remained blocks from recluster output.These logs describe selected input and pre-commit write observations, not committed snapshot deltas or complete failed-operation IO accounting. Input levels use the current cluster key's effective statistics; output levels reflect written blocks, including perfect level -1 and NULL for missing cluster statistics. No per-round correlation or new history table is introduced.
Tests
Type of change
AI assistance
This change is