refactor(query): remove proxy table engine - #20441
Open
sundy-li wants to merge 1 commit into
Open
Conversation
sundy-li
force-pushed
the
codex/remove-proxy-table
branch
from
September 5, 2026 16:08
cc59661 to
dbceac1
Compare
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
sundy-li
force-pushed
the
codex/remove-proxy-table
branch
from
September 7, 2026 01:50
dbceac1 to
7ec5749
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Remove the obsolete PROXY table engine now that the functionality can be replaced by materialized views. This removes the engine implementation, parser entry, storage factory registration, PROXY-specific settings, benchmark scripts, and the obsolete PROXY routing benchmark workflow job. The former routing coverage is preserved as materialized-view cost tests that verify choosing MV candidates by matching cluster-key predicates.
Tests
Validation run:
cargo fmt --allcargo check -p databend-common-ast -p databend-common-settings -p databend-common-storages-basic -p databend-common-storages-factory -p databend-common-storages-fusecargo check -p databend-querycargo check -p databend-common-storages-basic --testscargo test -p databend-common-settings --test it setting::test_set_settings -- --exact --test-threads=1UPDATE_GOLDENFILES=1 cargo test -p databend-query --test it storages::system::test_engines_table -- --exact --test-threads=1cargo test -p databend-query --test it storages::system::test_engines_table -- --exact --test-threads=1Note: full
cargo test -p databend-common-settings --test itwas also tried, but existing singleton/config ordering in that test binary caused unrelated failures outside this change.Type of change
AI assistance
This change is