feat(query): unify vacuum commands and execution - #20428
Open
SkyFan2002 wants to merge 16 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da66ac56d4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Unify table vacuum operations around the current VACUUM2 implementation and provide a consistent SQL command family.
This PR:
VACUUM TABLE <table>,VACUUM TABLES [FROM <database>], andVACUUM ALLcommandsOPTIMIZE TABLE <table> PURGEas a compatibility alias forVACUUM TABLETable::purge, legacydo_vacuum, old GC implementation, plans, interpreters, navigation helpers, and tests that only exercised those dead interfacesImplementation
OPTIMIZE TABLE ... PURGEsyntax directly toVacuumTable, avoiding a second execution path.Compatibility and risk
OPTIMIZE TABLE ... PURGEremains accepted and uses the same VACUUM2 behavior asVACUUM TABLE.PURGE BEFORE/snapshot-limit interfaces belonged to the obsolete execution path and are no longer exposed by the simplified vacuum syntax.Tests
Validation performed:
The VACUUM2 integration module completed with 9 passing tests. A repository-wide stale-symbol scan also found no remaining legacy
do_vacuum,Table::purge,do_purge, or old GC module references.Type of change
AI assistance
This change is