fix(query): refresh lambda types after planner rewrites - #20405
Draft
youngsofun wants to merge 1 commit into
Draft
fix(query): refresh lambda types after planner rewrites#20405youngsofun wants to merge 1 commit into
youngsofun wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 367ce2defc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
youngsofun
marked this pull request as draft
August 28, 2026 03:31
youngsofun
force-pushed
the
codex/fix-grouping-array-lambda
branch
from
August 28, 2026 03:56
367ce2d to
b753bb6
Compare
youngsofun
marked this pull request as ready for review
August 28, 2026 03:57
youngsofun
marked this pull request as draft
August 28, 2026 04:02
youngsofun
force-pushed
the
codex/fix-grouping-array-lambda
branch
from
August 28, 2026 16:29
b753bb6 to
e8dad40
Compare
youngsofun
marked this pull request as ready for review
August 28, 2026 16:30
youngsofun
marked this pull request as draft
September 2, 2026 01:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
GROUP BY CUBE/ROLLUPover an ARRAY column with an array-lambda predicate in HAVING panics withUnwindError 1104(BadDataValueType downcast failure) — both members of a logically-equivalent query pair fail #20381LambdaFunc::refresh_return_typeas the shared source of truth for binder construction, optimizer rewrites, and debug type validationNull,EmptyArray, andEmptyMapthrough post-bind rewrites without introducing internal errorsCUBEandROLLUPqueries over array grouping keys from constructing a non-nullable evaluator for nullable array values and panicking during downcastTests
Validation:
cargo test -p databend-common-sql --test it optimizer::type_consistency::test_optimizer_rewrites_keep_function_return_types_consistentcargo test -p databend-common-sql --test it semantic::type_check::lambda::test_type_check_lambda_functionscargo check -p databend-common-sqlcargo clippy -p databend-common-sql --tests -- -D warningscargo fmt --all --checkgit diff --checkType of change
AI assistance
This change is