Skip to content

fix(query): refresh lambda types after planner rewrites - #20405

Draft
youngsofun wants to merge 1 commit into
databendlabs:mainfrom
youngsofun:codex/fix-grouping-array-lambda
Draft

fix(query): refresh lambda types after planner rewrites#20405
youngsofun wants to merge 1 commit into
databendlabs:mainfrom
youngsofun:codex/fix-grouping-array-lambda

Conversation

@youngsofun

@youngsofun youngsofun commented Aug 28, 2026

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Validation:

  • cargo test -p databend-common-sql --test it optimizer::type_consistency::test_optimizer_rewrites_keep_function_return_types_consistent
  • cargo test -p databend-common-sql --test it semantic::type_check::lambda::test_type_check_lambda_functions
  • cargo check -p databend-common-sql
  • cargo clippy -p databend-common-sql --tests -- -D warnings
  • cargo fmt --all --check
  • git diff --check

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

AI assistance

  • AI usage: An AI coding agent assisted with root-cause analysis, implementation, regression tests, validation, reviewer feedback, and the PR draft
  • Responsible human: @youngsofun
  • The responsible human has read every line of this diff and can explain each change

This change is Reviewable

@github-actions github-actions Bot added the pr-bugfix this PR patches a bug in codebase label Aug 28, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 367ce2defc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@youngsofun
youngsofun marked this pull request as draft August 28, 2026 03:31
@youngsofun
youngsofun force-pushed the codex/fix-grouping-array-lambda branch from 367ce2d to b753bb6 Compare August 28, 2026 03:56
@youngsofun youngsofun changed the title fix(query): refresh lambda types after grouping rewrites fix(query): refresh lambda types after planner rewrites Aug 28, 2026
@youngsofun
youngsofun marked this pull request as ready for review August 28, 2026 03:57
@youngsofun
youngsofun marked this pull request as draft August 28, 2026 04:02
@youngsofun
youngsofun force-pushed the codex/fix-grouping-array-lambda branch from b753bb6 to e8dad40 Compare August 28, 2026 16:29
@youngsofun
youngsofun marked this pull request as ready for review August 28, 2026 16:30
@youngsofun
youngsofun marked this pull request as draft September 2, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

1 participant