fix(query): preserve nullable reflexive equality filters - #20390
Draft
youngsofun wants to merge 1 commit into
Draft
fix(query): preserve nullable reflexive equality filters#20390youngsofun wants to merge 1 commit into
youngsofun wants to merge 1 commit into
Conversation
youngsofun
marked this pull request as draft
August 26, 2026 10:57
youngsofun
force-pushed
the
codex/fix-20379
branch
2 times, most recently
from
August 26, 2026 12:39
5ea9be5 to
9f0a01f
Compare
youngsofun
marked this pull request as ready for review
August 26, 2026 12:40
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f0a01fcaa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
youngsofun
force-pushed
the
codex/fix-20379
branch
3 times, most recently
from
August 27, 2026 06:28
9f7f3e7 to
1555e80
Compare
youngsofun
marked this pull request as draft
August 28, 2026 10:03
youngsofun
force-pushed
the
codex/fix-20379
branch
from
August 28, 2026 10:04
1555e80 to
c0418e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
HAVING (AGG(col) = AGG(col))keeps groups whose aggregate is NULL — the same self-comparison in a projection column filters them correctly #20379.NULLsemantics are not lost.x = x.Tests
Validation performed:
cargo fmt --all -- --checkTEST_SUBDIR=regressions cargo test --package databend-common-sql --test it -- planner::test_lite_replay_service_optimizer_cases --exact --nocaptureTEST_SUBDIR=regressions cargo test --package databend-query --test it -- sql::planner::optimizer::optimizer_test::test_optimizer --exact --nocaptureTEST_SUBDIR=tpcds cargo test --package databend-common-sql --test it -- planner::test_lite_replay_service_optimizer_cases --exact --nocapturecargo clippy --package databend-common-sql --tests -- -D warningsType of change
Risk and performance
The optimizer only retains the original
x = xpredicate whenxis nullable. Non-nullable self-equalities still take the existing elimination path, and other equality inference is unchanged. Retaining the nullable predicate can also push the required NULL rejection closer to a scan.AI assistance
This change is