feat: Add support for DB_PASS_FILE #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for reading the database password from a file specified by the `DB_PASS_FILE` environment variable or the `--pass-file` CLI flag. - Added `--pass-file` flag and `DB_PASS_FILE` environment variable. - Updated logic in `cmd/root.go` to read the password from the specified file. - Ensured that an explicitly set password via `DB_PASS` or `--pass` takes precedence. - Updated documentation in `docs/configuration.md`. - Added tests in `cmd/dump_test.go` to cover the new functionality and precedence logic.
deitch
approved these changes
Jul 2, 2025
|
And particularly, thank you for adding the tests and the correct documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #422
I'm not used to go, so I asked https://jules.google/ to follow the issue instructions given by @deitch
This commit introduces support for reading the database password from a file specified by the
DB_PASS_FILEenvironment variable or the--pass-fileCLI flag.--pass-fileflag andDB_PASS_FILEenvironment variable.cmd/root.goto read the password from the specified file.DB_PASSor--passtakes precedence.docs/configuration.md.cmd/dump_test.goto cover the new functionality and precedence logic.