Skip to content

fixes path issue when reading dumps from s3 #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes path issue when reading dumps from s3 #435

wants to merge 2 commits into from
+2 −0

Conversation

shaunakv1
Copy link
Contributor

fixes #432

@shaunakv1 shaunakv1 mentioned this pull request Apr 30, 2025
Open
deitch
deitch requested changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key change is fine, but it looks like your IDE reformatted some indentation incorrectly. Can you fix so the only change is in s3.go:78? Just running gofmt -w -s s3.go should do it.

Thanks for this PR.

@shaunakv1
Copy link
Contributor Author

ah, I should enable whitespace in my github diffs. Done!

@deitch
Copy link
Collaborator

deitch commented May 2, 2025

Looks good. Can you squash to a single commit, and sign it with git commit -s?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch deitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore from s3://path/to/xxx.tgz does not work in docker-compose.yml
2 participants
@shaunakv1 @deitch