fix filename-pattern #340
Merged
fix filename-pattern #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #303 |
deitch
force-pushed
the
fix-filename-pattern
branch
from
fc74e35
to
2ddf727
Compare
Signed-off-by: Avi Deitcher <[email protected]>
deitch
force-pushed
the
fix-filename-pattern
branch
from
2ddf727
to
cb924f9
Compare
|
While I was at it, restructured the Besides making for better tests, it also gives us the ability to test |
Signed-off-by: Avi Deitcher <[email protected]>
deitch
force-pushed
the
fix-filename-pattern
branch
from
4cb70ba
to
b0938d5
Compare
|
And added FilenamePattern checking to the integration tests. As soon as this passes CI, we can merge in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not being reference. This should fix it.