Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch once env var to fit with others #318

Merged
merged 1 commit into from
Jun 30, 2024
Merged

switch once env var to fit with others #318

merged 1 commit into from
Jun 30, 2024

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Jun 30, 2024

The env vars for all dump configuration have the following characteristics:

  • start with DB_DUMP_
  • use the name of the CLI flag after the prefix, converted to upper-case, and with - switched to _

So --begin becomes DB_DUMP_BEGIN, etc.

There is one exception to this, --once which uses the env var RUN_ONCE rather than DB_DUMP_ONCE. This causes a lot of headaches, and libraries that do not handle it correctly, etc.

Since 1.0.0 is not yet GA, we are just switching the env var.

@deitch deitch merged commit 47a7840 into master Jun 30, 2024
2 checks passed
@deitch deitch deleted the handle-once-better branch June 30, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant