Add Dask-SQL example notebook #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c0b2f2.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
charlesbluca
commented
Mar 10, 2022
charlesbluca
commented
Mar 14, 2022
| @@ -0,0 +1,387 @@ | |||
| { | |||
There was a problem hiding this comment.
Does this note about the variable functionality of apply seem explicit enough? I could opt to break down the difference in performance on GPU vs CPU but wasn't sure if that would be overly verbose for this notebook.
Reply via ReviewNB
There was a problem hiding this comment.
I think this is fine - this is pretty much exactly what I would have written.
jacobtomlinson
approved these changes
May 16, 2022
There was a problem hiding this comment.
This looks great thanks @charlesbluca.
Looks like the CI failures are unrelated, but will need to be resolved before the examples website will get updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
Supersedes #171
This is just a revamp of the original Dask-SQL example notebook that @nils-braun got started a few months ago - hoping that we can iterate from here and hopefully get this merged in soon.
cc @randerzander @ayushdg