Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken mybinder links for dask-examples notebooks #112

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

GenevieveBuckley
Copy link
Collaborator

All the binder badge links are broken, this PR restores that functionality.

They broke for two reasons:

  1. The dask-examples "main" branch was recently renamed (previously named "master"), and
  2. A backwards incompatible change happened in the way binder generates/parses links (see here for more details)

Neither of these should be a problem going forward. However, we will need to be careful with the way people generate binder badges for dask-examples - if you use https://mybinder.org/ it will give you a link that only works for newer versions. We can either:

  • Use the link formatting with urlpath like in this PR, or
  • Update the pinned dependencies over at dask-examples to be more modern

Cross reference: dask/dask-examples#196

@GenevieveBuckley
Copy link
Collaborator Author

GenevieveBuckley commented Sep 17, 2021

(I'm not going to wait for discussion before merging, it's fixing a problem so we probably don't want to leave the links broken for longer than they need to be. I've checked the updated links individually & they all seem to be working now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant