Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure config storage is loaded #345

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: ensure config storage is loaded #345

merged 1 commit into from
Dec 2, 2024

Conversation

Ziinc
Copy link
Contributor

@Ziinc Ziinc commented Dec 2, 2024

Seems like function_exported/2 doesn't return true as the module isn't loaded at runtime.

@coveralls
Copy link

Pull Request Test Coverage Report for Build abd732048d9efaf50f8dc88e2404c683e808b69e-PR-345

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 92.658%
Files with Coverage Reduction New Missed Lines %
lib/broadway/topology/terminator.ex 1 92.86%
Totals Coverage Status
Change from base Build ddc2b199136d4cf7af93b68ac96aa84192b9d6dc: -0.1%
Covered Lines: 631
Relevant Lines: 681
💛 - Coveralls

@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@josevalim josevalim merged commit 3305b1c into dashbitco:main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ziinc @coveralls @josevalim