Generate for directive #738

scheglov · 2025-01-01T19:38:42Z

Continue #735

Note that it restores applies to annotated directives test, as discussed in the previous PR.
This functionality is indeed used, by package:checks generator.

The first version uses analyzer dependency override, because I want want you to look at the code before I publish analyzer .

…#736)

…art-lang#737) Bumps the github-actions group with 1 update: [actions/cache](https://github.com/actions/cache). Updates `actions/cache` from 4.1.2 to 4.2.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p> <blockquote> <h2>v4.2.0</h2> <h2>â� ï¸� Important Changes</h2> <p>The cache backend service has been rewritten from the ground up for improved performance and reliability. <a href="https://github.com/actions/cache">actions/cache</a> now integrates with the new cache service (v2) APIs.</p> <p>The new service will gradually roll out as of <strong>February 1st, 2025</strong>. The legacy service will also be sunset on the same date. Changes in these release are <strong>fully backward compatible</strong>.</p> <p><strong>We are deprecating some versions of this action</strong>. We recommend upgrading to version <code>v4</code> or <code>v3</code> as soon as possible before <strong>February 1st, 2025.</strong> (Upgrade instructions below).</p> <p>If you are using pinned SHAs, please use the SHAs of versions <code>v4.2.0</code> or <code>v3.4.0</code></p> <p>If you do not upgrade, all workflow runs using any of the deprecated <a href="https://github.com/actions/cache">actions/cache</a> will fail.</p> <p>Upgrading to the recommended versions will not break your workflows.</p> <p>Read more about the change & access the migration guide: <a href="https://github.com/actions/cache/discussions/1510">reference to the announcement</a>.</p> <h3>Minor changes</h3> <p>Minor and patch version updates for these dependencies:</p> <ul> <li><code>@â��actions/core</code>: <code>1.11.1</code></li> <li><code>@â��actions/io</code>: <code>1.1.3</code></li> <li><code>@â��vercel/ncc</code>: <code>0.38.3</code></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/cache/compare/v4...v4.2.0">https://github.com/actions/cache/compare/v4...v4.2.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/blob/main/RELEASES.md">actions/cache's changelog</a>.</em></p> <blockquote> <h1>Releases</h1> <h3>4.2.0</h3> <p>TLDR; The cache backend service has been rewritten from the ground up for improved performance and reliability. <a href="https://github.com/actions/cache">actions/cache</a> now integrates with the new cache service (v2) APIs.</p> <p>The new service will gradually roll out as of <strong>February 1st, 2025</strong>. The legacy service will also be sunset on the same date. Changes in these release are <strong>fully backward compatible</strong>.</p> <p><strong>We are deprecating some versions of this action</strong>. We recommend upgrading to version <code>v4</code> or <code>v3</code> as soon as possible before <strong>February 1st, 2025.</strong> (Upgrade instructions below).</p> <p>If you are using pinned SHAs, please use the SHAs of versions <code>v4.2.0</code> or <code>v3.4.0</code></p> <p>If you do not upgrade, all workflow runs using any of the deprecated <a href="https://github.com/actions/cache">actions/cache</a> will fail.</p> <p>Upgrading to the recommended versions will not break your workflows.</p> <h3>4.1.2</h3> <ul> <li>Add GitHub Enterprise Cloud instances hostname filters to inform API endpoint choices - <a href="https://redirect.github.com/actions/cache/pull/1474">#1474</a></li> <li>Security fix: Bump braces from 3.0.2 to 3.0.3 - <a href="https://redirect.github.com/actions/cache/pull/1475">#1475</a></li> </ul> <h3>4.1.1</h3> <ul> <li>Restore original behavior of <code>cache-hit</code> output - <a href="https://redirect.github.com/actions/cache/pull/1467">#1467</a></li> </ul> <h3>4.1.0</h3> <ul> <li>Ensure <code>cache-hit</code> output is set when a cache is missed - <a href="https://redirect.github.com/actions/cache/pull/1404">#1404</a></li> <li>Deprecate <code>save-always</code> input - <a href="https://redirect.github.com/actions/cache/pull/1452">#1452</a></li> </ul> <h3>4.0.2</h3> <ul> <li>Fixed restore <code>fail-on-cache-miss</code> not working.</li> </ul> <h3>4.0.1</h3> <ul> <li>Updated <code>isGhes</code> check</li> </ul> <h3>4.0.0</h3> <ul> <li>Updated minimum runner version support from node 12 -> node 20</li> </ul> <h3>3.4.0</h3> <ul> <li>Integrated with the new cache service (v2) APIs</li> </ul> <h3>3.3.3</h3> <ul> <li>Updates <code>@â��actions/cache</code> to v3.2.3 to fix accidental mutated path arguments to <code>getCacheVersion</code> <a href="https://redirect.github.com/actions/toolkit/pull/1378">actions/toolkit#1378</a></li> <li>Additional audit fixes of npm package(s)</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/cache/commit/1bd1e32a3bdc45362d1e726936510720a7c30a57"><code>1bd1e32</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1509">#1509</a> from actions/Link-/cache-4.2.0</li> <li><a href="https://github.com/actions/cache/commit/882d7ced4c9b8af53ed67bfa36ee600195e62940"><code>882d7ce</code></a> Add 3.4.0 release notes</li> <li><a href="https://github.com/actions/cache/commit/f2695d7a42dd0d7ad21976ed7ab91dbdbc3c2216"><code>f2695d7</code></a> Rerun CI</li> <li><a href="https://github.com/actions/cache/commit/f46ceeb60d3da27b7cbac269520a4b1bfb15f199"><code>f46ceeb</code></a> Add licensed output</li> <li><a href="https://github.com/actions/cache/commit/e6f5858749f178cf4a01b0d777917ba913710560"><code>e6f5858</code></a> Add lodash to list of reviewed licenses</li> <li><a href="https://github.com/actions/cache/commit/4ae6f21c0d820c73db2589af6983e001d8c19c1d"><code>4ae6f21</code></a> Add reviewed licensed packages</li> <li><a href="https://github.com/actions/cache/commit/c16df86586baf94b0deaa873e22eb739c59e5b15"><code>c16df86</code></a> Add licensed output</li> <li><a href="https://github.com/actions/cache/commit/b109c12f3bdd6fb6a7dd42b202df645243efbd2f"><code>b109c12</code></a> Upgrade <code>@â��actions/core</code> to 1.11.1 and other deps</li> <li><a href="https://github.com/actions/cache/commit/b7d227d702af06e6be1fa308c014252c10bbc267"><code>b7d227d</code></a> Upgrade <code>@â��vercel/ncc</code> to 0.38.3</li> <li><a href="https://github.com/actions/cache/commit/faf639248d95d2a6c5884b8e6588e233eb3b10a0"><code>faf6392</code></a> Update RELEASES.md</li> <li>Additional commits viewable in <a href="https://github.com/actions/cache/compare/6849a6489940f00c2f30c0fb92c6274307ccb58a...1bd1e32a3bdc45362d1e726936510720a7c30a57">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/cache&package-manager=github_actions&previous-version=4.1.2&new-version=4.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details>

jakemac53

LGTM but I don't have too much context for this particular API so @kevmoo might want to look?

kevmoo · 2025-01-06T20:14:50Z

@scheglov – needs to do some tweaks here, it appears.

kevmoo · 2025-01-06T20:15:51Z

source_gen/pubspec.yaml

 dependency_overrides:
-  analyzer: ^7.1.0
+  analyzer:
+    path: /Users/scheglov/Source/Dart/sdk.git/sdk/pkg/analyzer
  build:
    git:
      url: https://github.com/dart-lang/build.git


Should just delete this section, right?

Oh, definitely need to use an actual published analyzer.
I need to know if the general approach looks good to you.
If it is, I will publish the analyzer, and update the dependency.

OK, I don't see any objections, so I will move forward with publishing the required analyzer version.
https://dart-review.googlesource.com/c/sdk/+/403264

Uh...I haven't had time to reason about this change yet, honestly.

What is ETA for reviewing this?

kevmoo · 2025-01-06T20:19:01Z

source_gen/lib/src/generator_for_annotation.dart

+  ///
+  /// Implementations should return `null` when no content is generated. Empty
+  /// or whitespace-only [String] instances are also ignored.
+  dynamic generateForAnnotatedDirective(


What's the deal w/ this @scheglov ?

I'm sorry, i don't understand the question.
This method is invoked at the line 62.

We cannot use the same method for elements and directive.

I think we can skip this for now if checks is the only known usage that needs it. I can add it later if it becomes necessary.

We will need to be careful not to break internal uses of this and document carefully the impact when we publish externally since this is fairly subtle and it isn't clear in source code exactly when it will matter.

kevmoo · 2025-01-14T21:12:58Z

source_gen/lib/src/generator_for_annotation.dart

GeneratorForAnnotation should be extends-able but not implements-able.
This is base, right?

source_gen/CHANGELOG.md

…art-lang#741) Bumps the github-actions group with 1 update: [actions/stale](https://github.com/actions/stale). Updates `actions/stale` from 9.0.0 to 9.1.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/stale/releases">actions/stale's releases</a>.</em></p> <blockquote> <h2>v9.1.0</h2> <h2>What's Changed</h2> <ul> <li>Documentation update by <a href="https://github.com/Marukome0743"><code>@Marukome0743</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1116">actions/stale#1116</a></li> <li>Add workflow file for publishing releases to immutable action package by <a href="https://github.com/Jcambass"><code>@Jcambass</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1179">actions/stale#1179</a></li> <li>Update undici from 5.28.2 to 5.28.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1150">actions/stale#1150</a></li> <li>Update actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1091">actions/stale#1091</a></li> <li>Update actions/publish-action from 0.2.2 to 0.3.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1147">actions/stale#1147</a></li> <li>Update ts-jest from 29.1.1 to 29.2.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1175">actions/stale#1175</a></li> <li>Update <code>@actions/core</code> from 1.10.1 to 1.11.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1191">actions/stale#1191</a></li> <li>Update <code>@types/jest</code> from 29.5.11 to 29.5.14 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1193">actions/stale#1193</a></li> <li>Update <code>@actions/cache</code> from 3.2.2 to 4.0.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1194">actions/stale#1194</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Marukome0743"><code>@Marukome0743</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1116">actions/stale#1116</a></li> <li><a href="https://github.com/Jcambass"><code>@Jcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1179">actions/stale#1179</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/stale/compare/v9...v9.1.0">https://github.com/actions/stale/compare/v9...v9.1.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/stale/commit/5bef64f19d7facfb25b37b414482c7164d639639"><code>5bef64f</code></a> build(deps): bump <code>@actions/cache</code> from 3.2.2 to 4.0.0 (<a href="https://redirect.github.com/actions/stale/issues/1194">#1194</a>)</li> <li><a href="https://github.com/actions/stale/commit/fa77dfddd04682b7d96dbc4e016318e681fdc10e"><code>fa77dfd</code></a> build(deps-dev): bump <code>@types/jest</code> from 29.5.11 to 29.5.14 (<a href="https://redirect.github.com/actions/stale/issues/1193">#1193</a>)</li> <li><a href="https://github.com/actions/stale/commit/f04443dce335c74ba15c65f4cbb3688e6cb6a6ec"><code>f04443d</code></a> build(deps): bump <code>@actions/core</code> from 1.10.1 to 1.11.1 (<a href="https://redirect.github.com/actions/stale/issues/1191">#1191</a>)</li> <li><a href="https://github.com/actions/stale/commit/5c715b0513651880806e14d529f014b12fdd50eb"><code>5c715b0</code></a> build(deps-dev): bump ts-jest from 29.1.1 to 29.2.5 (<a href="https://redirect.github.com/actions/stale/issues/1175">#1175</a>)</li> <li><a href="https://github.com/actions/stale/commit/f69122271d990fd11f5594ccff2296f00ff59b49"><code>f691222</code></a> build(deps): bump actions/publish-action from 0.2.2 to 0.3.0 (<a href="https://redirect.github.com/actions/stale/issues/1147">#1147</a>)</li> <li><a href="https://github.com/actions/stale/commit/df990c2cf5ae92c90653c9485d6882a0a09feac7"><code>df990c2</code></a> build(deps): bump actions/checkout from 3 to 4 (<a href="https://redirect.github.com/actions/stale/issues/1091">#1091</a>)</li> <li><a href="https://github.com/actions/stale/commit/6e472ce44ab4197b0154601c59c54a75b73b340b"><code>6e472ce</code></a> Merge pull request <a href="https://redirect.github.com/actions/stale/issues/1179">#1179</a> from actions/Jcambass-patch-1</li> <li><a href="https://github.com/actions/stale/commit/d10ba64261d965f75165f74c55cd3ffbf690d442"><code>d10ba64</code></a> Merge pull request <a href="https://redirect.github.com/actions/stale/issues/1150">#1150</a> from actions/dependabot/npm_and_yarn/undici-5.28.4</li> <li><a href="https://github.com/actions/stale/commit/bbf3da5f64eebd003932d93293857400f7f7e18d"><code>bbf3da5</code></a> resolve check failures</li> <li><a href="https://github.com/actions/stale/commit/6a2e61d18b155e538f85ef1bf7bd0470775e9703"><code>6a2e61d</code></a> Add workflow file for publishing releases to immutable action package</li> <li>Additional commits viewable in <a href="https://github.com/actions/stale/compare/28ca1036281a5e5922ead5184a1bbf96e5fc984e...5bef64f19d7facfb25b37b414482c7164d639639">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/stale&package-manager=github_actions&previous-version=9.0.0&new-version=9.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details>

Bumps the github-actions group with 2 updates: [actions/cache](https://github.com/actions/cache) and [dart-lang/setup-dart](https://github.com/dart-lang/setup-dart). Updates `actions/cache` from 4.2.0 to 4.2.2 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p> <blockquote> <h2>v4.2.2</h2> <h2>What's Changed</h2> <blockquote> <p>[!IMPORTANT] As a reminder, there were important backend changes to release v4.2.0, see <a href="https://github.com/actions/cache/releases/tag/v4.2.0">those release notes</a> and <a href="https://github.com/actions/cache/discussions/1510">the announcement</a> for more details.</p> </blockquote> <ul> <li>Bump <code>@actions/cache</code> to v4.0.2 by <a href="https://github.com/robherley"><code>@robherley</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1560">actions/cache#1560</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/cache/compare/v4.2.1...v4.2.2">https://github.com/actions/cache/compare/v4.2.1...v4.2.2</a></p> <h2>v4.2.1</h2> <h2>What's Changed</h2> <blockquote> <p>[!IMPORTANT] As a reminder, there were important backend changes to release v4.2.0, see <a href="https://github.com/actions/cache/releases/tag/v4.2.0">those release notes</a> and <a href="https://github.com/actions/cache/discussions/1510">the announcement</a> for more details.</p> </blockquote> <ul> <li>docs: GitHub is spelled incorrectly in caching-strategies.md by <a href="https://github.com/janco-absa"><code>@janco-absa</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1526">actions/cache#1526</a></li> <li>docs: Make the "always save prime numbers" example more clear by <a href="https://github.com/Tobbe"><code>@Tobbe</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1525">actions/cache#1525</a></li> <li>Update force deletion docs due a recent deprecation by <a href="https://github.com/sebbalex"><code>@sebbalex</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1500">actions/cache#1500</a></li> <li>Bump <code>@actions/cache</code> to v4.0.1 by <a href="https://github.com/robherley"><code>@robherley</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1554">actions/cache#1554</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/janco-absa"><code>@janco-absa</code></a> made their first contribution in <a href="https://redirect.github.com/actions/cache/pull/1526">actions/cache#1526</a></li> <li><a href="https://github.com/Tobbe"><code>@Tobbe</code></a> made their first contribution in <a href="https://redirect.github.com/actions/cache/pull/1525">actions/cache#1525</a></li> <li><a href="https://github.com/sebbalex"><code>@sebbalex</code></a> made their first contribution in <a href="https://redirect.github.com/actions/cache/pull/1500">actions/cache#1500</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/cache/compare/v4.2.0...v4.2.1">https://github.com/actions/cache/compare/v4.2.0...v4.2.1</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/blob/main/RELEASES.md">actions/cache's changelog</a>.</em></p> <blockquote> <h1>Releases</h1> <h3>4.2.2</h3> <ul> <li>Bump <code>@actions/cache</code> to v4.0.2</li> </ul> <h3>4.2.1</h3> <ul> <li>Bump <code>@actions/cache</code> to v4.0.1</li> </ul> <h3>4.2.0</h3> <p>TLDR; The cache backend service has been rewritten from the ground up for improved performance and reliability. <a href="https://github.com/actions/cache">actions/cache</a> now integrates with the new cache service (v2) APIs.</p> <p>The new service will gradually roll out as of <strong>February 1st, 2025</strong>. The legacy service will also be sunset on the same date. Changes in these release are <strong>fully backward compatible</strong>.</p> <p><strong>We are deprecating some versions of this action</strong>. We recommend upgrading to version <code>v4</code> or <code>v3</code> as soon as possible before <strong>February 1st, 2025.</strong> (Upgrade instructions below).</p> <p>If you are using pinned SHAs, please use the SHAs of versions <code>v4.2.0</code> or <code>v3.4.0</code></p> <p>If you do not upgrade, all workflow runs using any of the deprecated <a href="https://github.com/actions/cache">actions/cache</a> will fail.</p> <p>Upgrading to the recommended versions will not break your workflows.</p> <h3>4.1.2</h3> <ul> <li>Add GitHub Enterprise Cloud instances hostname filters to inform API endpoint choices - <a href="https://redirect.github.com/actions/cache/pull/1474">#1474</a></li> <li>Security fix: Bump braces from 3.0.2 to 3.0.3 - <a href="https://redirect.github.com/actions/cache/pull/1475">#1475</a></li> </ul> <h3>4.1.1</h3> <ul> <li>Restore original behavior of <code>cache-hit</code> output - <a href="https://redirect.github.com/actions/cache/pull/1467">#1467</a></li> </ul> <h3>4.1.0</h3> <ul> <li>Ensure <code>cache-hit</code> output is set when a cache is missed - <a href="https://redirect.github.com/actions/cache/pull/1404">#1404</a></li> <li>Deprecate <code>save-always</code> input - <a href="https://redirect.github.com/actions/cache/pull/1452">#1452</a></li> </ul> <h3>4.0.2</h3> <ul> <li>Fixed restore <code>fail-on-cache-miss</code> not working.</li> </ul> <h3>4.0.1</h3> <ul> <li>Updated <code>isGhes</code> check</li> </ul> <h3>4.0.0</h3> <ul> <li>Updated minimum runner version support from node 12 -> node 20</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/cache/commit/d4323d4df104b026a6aa633fdb11d772146be0bf"><code>d4323d4</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1560">#1560</a> from actions/robherley/v4.2.2</li> <li><a href="https://github.com/actions/cache/commit/da26677639ccfb4615f1acc52d1fc3dc89152490"><code>da26677</code></a> bump <code>@actions/cache</code> to v4.0.2, prep for v4.2.2 release</li> <li><a href="https://github.com/actions/cache/commit/7921ae235bdcb376cc8f22558dc5f8ddc3c3c2f9"><code>7921ae2</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1557">#1557</a> from actions/robherley/ia-workflow-released</li> <li><a href="https://github.com/actions/cache/commit/393773170624981bfaa3aac1cb736e3004eac1de"><code>3937731</code></a> Update publish-immutable-actions.yml</li> <li><a href="https://github.com/actions/cache/commit/0c907a75c2c80ebcb7f088228285e798b750cf8f"><code>0c907a7</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1554">#1554</a> from actions/robherley/v4.2.1</li> <li><a href="https://github.com/actions/cache/commit/710893c2369beb60748049b671f18c43a3656fce"><code>710893c</code></a> bump <code>@actions/cache</code> to v4.0.1</li> <li><a href="https://github.com/actions/cache/commit/9fa7e61ec7e1f44ac75218e7aaea81da8856fd11"><code>9fa7e61</code></a> Update force deletion docs due a recent deprecation (<a href="https://redirect.github.com/actions/cache/issues/1500">#1500</a>)</li> <li><a href="https://github.com/actions/cache/commit/36f1e144e1c8edb0a652766b484448563d8baf46"><code>36f1e14</code></a> docs: Make the "always save prime numbers" example more clear (<a href="https://redirect.github.com/actions/cache/issues/1525">#1525</a>)</li> <li><a href="https://github.com/actions/cache/commit/53aa38c736a561b9c17b62df3fe885a17b78ee6d"><code>53aa38c</code></a> Correct GitHub Spelling in caching-strategies.md (<a href="https://redirect.github.com/actions/cache/issues/1526">#1526</a>)</li> <li>See full diff in <a href="https://github.com/actions/cache/compare/1bd1e32a3bdc45362d1e726936510720a7c30a57...d4323d4df104b026a6aa633fdb11d772146be0bf">compare view</a></li> </ul> </details> <br /> Updates `dart-lang/setup-dart` from 1.7.0 to 1.7.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dart-lang/setup-dart/releases">dart-lang/setup-dart's releases</a>.</em></p> <blockquote> <h2>v1.7.1</h2> <ul> <li>Roll <code>undici</code> dependency to address <a href="https://github.com/nodejs/undici/security/advisories/GHSA-c76h-2ccp-4975">CVE-2025-22150</a>.</li> <li>Update to the latest npm dependencies.</li> <li>Recompile the action using the new Dart / JavaScript interop.</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/dart-lang/setup-dart/blob/main/CHANGELOG.md">dart-lang/setup-dart's changelog</a>.</em></p> <blockquote> <h2>v1.7.1</h2> <ul> <li>Roll <code>undici</code> dependency to address <a href="https://github.com/nodejs/undici/security/advisories/GHSA-c76h-2ccp-4975">CVE-2025-22150</a>.</li> <li>Update to the latest npm dependencies.</li> <li>Recompile the action using the new Dart / JavaScript interop.</li> </ul> <h2>v1.7.0</h2> <ul> <li> <p>Install flutter sdk in publishing step, allowing Flutter packages to be published (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/68">#68</a>[])</p> <p><a href="https://redirect.github.com/dart-lang/setup-dart/issues/68">#68</a>: <a href="https://redirect.github.com/dart-lang/setup-dart/issues/68">dart-lang/setup-dart#68</a></p> </li> </ul> <h2>v1.6.5</h2> <ul> <li>Fix zip path handling on Windows 11 (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/118">#118</a>[])</li> </ul> <p><a href="https://redirect.github.com/dart-lang/setup-dart/issues/118">#118</a>: <a href="https://redirect.github.com/dart-lang/setup-dart/issues/118">dart-lang/setup-dart#118</a></p> <h2>v1.6.4</h2> <ul> <li>Rebuild JS code.</li> </ul> <h2>v1.6.3</h2> <ul> <li>Roll <code>undici</code> dependency to address <a href="https://github.com/nodejs/undici/security/advisories/GHSA-m4v8-wqvr-p9f7">CVE-2024-30260</a> and <a href="https://github.com/nodejs/undici/security/advisories/GHSA-9qxr-qj54-h672">CVE-2024-30261</a>.</li> </ul> <h2>v1.6.2</h2> <ul> <li>Switch to running the workflow on <code>node20`` from </code>node16`. See also <a href="https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/">Transitioning from Node 16 to Node 20</a>.</li> </ul> <h2>v1.6.1</h2> <ul> <li>Updated the google storage url for <code>main</code> channel releases.</li> </ul> <h2>v1.6.0</h2> <ul> <li>Enable provisioning of the latest Dart SDK patch release by specifying just the major and minor version (e.g. <code>3.2</code>).</li> </ul> <h2>v1.5.1</h2> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dart-lang/setup-dart/commit/e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c"><code>e51d8e5</code></a> prep for releasing 1.7.1 (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/150">#150</a>)</li> <li><a href="https://github.com/dart-lang/setup-dart/commit/1faf8e64e5464d6b727016aa2467794f7dc410fb"><code>1faf8e6</code></a> updates to move away from dart:js_util (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/148">#148</a>)</li> <li><a href="https://github.com/dart-lang/setup-dart/commit/614cb8d798824d682e7086a5d8b14e588723bc5c"><code>614cb8d</code></a> Bump flutter-actions/setup-flutter in the github-actions group (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/146">#146</a>)</li> <li><a href="https://github.com/dart-lang/setup-dart/commit/55f49ad7b2b8b71f3043f80dc4cd4e0eca4aa90b"><code>55f49ad</code></a> Bump undici from 5.28.4 to 5.28.5 (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/149">#149</a>)</li> <li><a href="https://github.com/dart-lang/setup-dart/commit/2c0db8f5ec902ee2420de88e6ece2f275d1f26f1"><code>2c0db8f</code></a> Bump <code>@actions/tool-cache</code> from 2.0.1 to 2.0.2 (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/147">#147</a>)</li> <li><a href="https://github.com/dart-lang/setup-dart/commit/6123db65aca0aa1e30809215875310f1ca706148"><code>6123db6</code></a> Bump dart-lang/setup-dart in the github-actions group (<a href="https://redirect.github.com/dart-lang/setup-dart/issues/145">#145</a>)</li> <li>See full diff in <a href="https://github.com/dart-lang/setup-dart/compare/e630b99d28a3b71860378cafdc2a067c71107f94...e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details>

jakemac53 · 2025-03-11T22:11:37Z

source_gen/CHANGELOG.md

- Require `analyzer: ^6.9.0`
- Require Dart 3.6.0
+- Require `analyzer: '>=7.2.0 <8.0.0'`
+- Support the latest `package:dart_style`


We should mention the new API here

I wrote something, but I'm not sure if this is exactly what you expected.

source_gen/lib/src/generator_for_annotation.dart

jakemac53 · 2025-03-12T13:53:14Z

source_gen/CHANGELOG.md

+- Add `generateForAnnotatedDirective` in addition to `generateForAnnotatedElement2`
+  because in the analyzer element model V2 directives are not elements.


Suggested change

- Add `generateForAnnotatedDirective` in addition to `generateForAnnotatedElement2`

because in the analyzer element model V2 directives are not elements.

- Add `generateForAnnotatedDirective`, which now must be used instead of `generateForAnnotatedElement` in order to support annotations on directives (imports, exports, parts, etc).

source_gen/test/generator_for_annotation_test.dart

jakemac53 · 2025-03-12T17:53:57Z

@scheglov can you merge this with master and push? I think that will fix the CI issue.

kevmoo · 2025-03-12T18:18:35Z

Landing #744 to fix the CI issues

kevmoo · 2025-03-12T18:22:33Z

Ha! Yeah, just a rebase is fine

scheglov · 2025-03-12T18:25:13Z

I'm not so versed in GitHub lingo, so I for sure can click "Squash and merge" or "Rebase and merge".
But I don't understand which of these you want me to do, if any.
And even more I don't understand if you could do it yourself as owners of the repository :-)

kevmoo · 2025-03-12T18:31:58Z

With generate-for-directive branch checkout

git fetch --all; git merge origin/master

scheglov · 2025-03-12T18:38:46Z

Thanks. Probably nothing happened.

~/dart/source_gen (generate-for-directive)$ git fetch --all; git merge origin/master
Fetching origin
Fetching upstream
From https://github.com/dart-lang/source_gen
   947a0e2..34f9264  master     -> upstream/master
Already up to date.

kevmoo · 2025-03-12T18:40:49Z

Oh! do git merge upstream/master then

…ctive

kevmoo · 2025-03-12T18:48:20Z

Oh! you're trying to merge into your special branch.

You should change your merge into master

scheglov · 2025-03-12T18:49:45Z

OK, I did what I think you asked for :-)

kevmoo · 2025-03-12T18:52:09Z

Yep! Because we want to ship this, right?

Now we just need to fig errors!

kevmoo · 2025-03-12T18:52:37Z

source_gen/pubspec.yaml

@@ -26,3 +27,32 @@ dev_dependencies:
  dart_flutter_team_lints: ^3.1.0
  term_glyph: ^1.2.0
  test: ^1.16.0
+
+dependency_overrides:


Gotta drop all of these, right?

scheglov · 2025-03-12T18:55:29Z

Theoretically this is the approach that I always done in the past: have old API (deprecated), new API, publish, migrate clients, remove old API, publish. Two interdependent changes from this now are: (1) I was told that we don't want to publish with two APIs; (2) we don't have old APIs deprecated. So, right now I'm just doing what I'm told, with the expectation that the owners know what should happen.

scheglov · 2025-03-12T18:58:23Z

The current states of build and source_gen were supposed to be enough to support migration of google3.
See above, about not publishing two versions of APIs.
So, I suspect that if I remove dependency overrides, everything will be still broken :-(

kevmoo · 2025-03-12T19:34:48Z

I guess you'll have to update the analyzer dep, though – likely to a github dep?

jakemac53 · 2025-03-12T20:27:51Z

So, I thought we did want to keep this only merged into the https://github.com/dart-lang/source_gen/tree/analyzer-element2 branch?

We would merge into master once we can replace the existing APIs entirely with the new ones, instead of having both. Both would only exist in that branch, and only for internal migration purposes.

We could have separately updated the analyzer-element2 branch to merge in master also... but I was suggesting to just do it as a part of this PR because it might be easier.

scheglov · 2025-03-12T21:23:24Z

OK, I switch this PR back to analyzer-element2.

jakemac53 · 2025-03-13T16:33:58Z

Not sure what the best thing to do is regarding the lint failures, should we just add ignore_for_file comments throughout? I am a bit concerned they will never get removed.

scheglov · 2025-03-13T16:48:28Z

This PR is not a migration of source_gen.
It is adding APIs that are required for the migration of the clients of source_gen.
Once here are no users of V1 element model, we will finish source_gen migration.

jakemac53 · 2025-03-13T17:20:25Z

Yes I understand, but we do want the CI jobs to still run and be green on this branch ideally.

I would add ignore comments for the lints, because I realize now that we will definitely see them when we go to actually merge things into master, so we can know to delete them at that time.

scheglov · 2025-03-13T17:36:09Z

OK, I disabled analyzer_use_new_elements for now, but there are still failures because of using deprecated APIs.
Are these should be ignored individually?
Is it intentional that they break bots?

kevmoo and others added 4 commits December 17, 2024 08:52

Support latest analyzer and dart_style, prepare v2 release (dart-lang…

947a0e2

…#736)

Support latest analyzer and dart_style, prepare v2 release (dart-lang…

0aa4656

…#736)

Elements. Support for generateForAnnotatedDirective() and related.

c6f1dfb

scheglov requested a review from jakemac53 January 3, 2025 18:50

jakemac53 approved these changes Jan 6, 2025

View reviewed changes

kevmoo reviewed Jan 6, 2025

View reviewed changes

kevmoo reviewed Jan 14, 2025

View reviewed changes

source_gen/CHANGELOG.md Show resolved Hide resolved

scheglov and others added 3 commits January 27, 2025 07:41

tweak

508c6c6

srawlins mentioned this pull request Mar 7, 2025

Release version with analyzer's Element2 APIs #743

Open

jakemac53 reviewed Mar 11, 2025

View reviewed changes

source_gen/lib/src/generator_for_annotation.dart Outdated Show resolved Hide resolved

tweak

f8cac87

jakemac53 reviewed Mar 12, 2025

View reviewed changes

source_gen/test/generator_for_annotation_test.dart Show resolved Hide resolved

tweak

8e9138f

Merge remote-tracking branch 'upstream/master' into generate-for-dire…

72c79d0

…ctive

scheglov changed the base branch from analyzer-element2 to master March 12, 2025 18:49

kevmoo reviewed Mar 12, 2025

View reviewed changes

Use git dependency override for analyzer.

98edcac

scheglov changed the base branch from master to analyzer-element2 March 12, 2025 21:22

Disable analyzer_use_new_elements for now.

589ccf5

scheglov added 2 commits March 15, 2025 09:22

deprecations

39075e9

lints

5134899

jakemac53 approved these changes Mar 17, 2025

View reviewed changes

jakemac53 merged commit ee4960c into dart-lang:analyzer-element2 Mar 17, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate for directive #738

Generate for directive #738

scheglov commented Jan 1, 2025 •

edited

Loading

jakemac53 left a comment

kevmoo commented Jan 6, 2025

kevmoo Jan 6, 2025

scheglov Jan 6, 2025

scheglov Jan 7, 2025

kevmoo Jan 7, 2025

scheglov Jan 10, 2025

kevmoo Jan 6, 2025

scheglov Jan 6, 2025

natebosch Jan 27, 2025

kevmoo Jan 14, 2025

jakemac53 Mar 11, 2025

scheglov Mar 12, 2025

jakemac53 Mar 12, 2025

jakemac53 commented Mar 12, 2025

kevmoo commented Mar 12, 2025

kevmoo commented Mar 12, 2025

scheglov commented Mar 12, 2025

kevmoo commented Mar 12, 2025

scheglov commented Mar 12, 2025

kevmoo commented Mar 12, 2025

kevmoo commented Mar 12, 2025

scheglov commented Mar 12, 2025

kevmoo commented Mar 12, 2025

kevmoo Mar 12, 2025

scheglov commented Mar 12, 2025

scheglov commented Mar 12, 2025

kevmoo commented Mar 12, 2025

jakemac53 commented Mar 12, 2025

scheglov commented Mar 12, 2025

jakemac53 commented Mar 13, 2025

scheglov commented Mar 13, 2025

jakemac53 commented Mar 13, 2025

scheglov commented Mar 13, 2025

		- Add `generateForAnnotatedDirective` in addition to `generateForAnnotatedElement2`
		because in the analyzer element model V2 directives are not elements.

	- Add `generateForAnnotatedDirective` in addition to `generateForAnnotatedElement2`
	because in the analyzer element model V2 directives are not elements.
	- Add `generateForAnnotatedDirective`, which now must be used instead of `generateForAnnotatedElement` in order to support annotations on directives (imports, exports, parts, etc).

Generate for directive #738

Generate for directive #738

Conversation

scheglov commented Jan 1, 2025 • edited Loading

jakemac53 left a comment

Choose a reason for hiding this comment

kevmoo commented Jan 6, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakemac53 commented Mar 12, 2025

kevmoo commented Mar 12, 2025

kevmoo commented Mar 12, 2025

scheglov commented Mar 12, 2025

kevmoo commented Mar 12, 2025

scheglov commented Mar 12, 2025

kevmoo commented Mar 12, 2025

kevmoo commented Mar 12, 2025

scheglov commented Mar 12, 2025

kevmoo commented Mar 12, 2025

Choose a reason for hiding this comment

scheglov commented Mar 12, 2025

scheglov commented Mar 12, 2025

kevmoo commented Mar 12, 2025

jakemac53 commented Mar 12, 2025

scheglov commented Mar 12, 2025

jakemac53 commented Mar 13, 2025

scheglov commented Mar 13, 2025

jakemac53 commented Mar 13, 2025

scheglov commented Mar 13, 2025

scheglov commented Jan 1, 2025 •

edited

Loading