Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built_value for comparison in tests #3916

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Mar 11, 2025

For #3811.

built_value generates toString and operator== so this test support code can go away.

There's also a built_value "matcher" if we want it, in package:built_value_test, which produces nicer messages about what didn't match, but it doesn't look worth using (yet).

Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

@davidmorgan davidmorgan changed the title Test built Use built_value for comparison in tests Mar 11, 2025
@davidmorgan davidmorgan requested a review from jensjoha March 13, 2025 07:54
@davidmorgan davidmorgan marked this pull request as ready for review March 13, 2025 07:54
@davidmorgan davidmorgan merged commit 4894f0b into dart-lang:master Mar 13, 2025
75 checks passed
@davidmorgan davidmorgan deleted the test-built branch March 13, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants