Merge AssetWriterSpy functionality into SingleStepReader.
#3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
davidmorgan
force-pushed
the
remove-written-asset-reader
branch
3 times, most recently
from
590d5f1 to
7a51caa
Compare
davidmorgan
changed the title
AssetWriterSpy functionality into SingleStepReader.
davidmorgan
force-pushed
the
remove-written-asset-reader
branch
from
7a51caa to
b3012c6
Compare
… `SingleStepReaderWriter`.
davidmorgan
force-pushed
the
remove-written-asset-reader
branch
from
b3012c6 to
b87bb92
Compare
jensjoha
approved these changes
Feb 28, 2025
| ), | ||
| runningBuildStep: RunningBuildStep( | ||
| phaseNumber: phaseNumber, | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811.
SingleStepReaderbecomesSingleStepReaderWriter. Use it explicitly where it makes sense, add internal-onlyAssetReaderWriterand use that where it makes sense. Convert fromAssetReader+AssetWriterin public APIs to oneAssetReaderWriter/ReaderWriter/SingleStepReaderWriterin internal APIs.Codepath used for testing that partly simulates a build is now called out explicitly.