Remove BuildCacheWriter and OnDeleteWriter
#3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Health |
davidmorgan
force-pushed
the
remove-cache-writer
branch
2 times, most recently
from
b1f7aaa to
6d49554
Compare
davidmorgan
changed the title
BuildCacheWriter and OnDeleteWriter
davidmorgan
force-pushed
the
remove-cache-writer
branch
from
6d49554 to
a157df2
Compare
davidmorgan
force-pushed
the
remove-cache-writer
branch
from
a157df2 to
8377434
Compare
davidmorgan
force-pushed
the
remove-cache-writer
branch
from
8377434 to
61f4984
Compare
jensjoha
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811.
ReaderWriterusesAssetPathProviderfor writes as well as reads, so no writer wrapper is needed.OnDeleteWriterfunctionality is already inTestReaderWriter, it turns out it's needed for prod code too, so move it toReaderWriterand add tocopyWith.