Refactor PathProvidingAssetReader to AssetPathProvider
#3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
davidmorgan
force-pushed
the
fewer-readers
branch
from
7b46625 to
cf9ba8d
Compare
davidmorgan
changed the title
PathProvidingAssetReader to AssetPathProvider
davidmorgan
force-pushed
the
fewer-readers
branch
from
cf9ba8d to
1c6676d
Compare
davidmorgan
force-pushed
the
fewer-readers
branch
from
1c6676d to
94e000f
Compare
jensjoha
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811.
Refactor
PathProvidingAssetReadertoAssetPathProvider.Inheritance just gets in the way here, the capability to map
AssetId->path is better expressed via composition.