Support for per-field limits#15
Open
JamesSkemp wants to merge 1 commit intodarrentaytay:masterfrom
JamesSkemp:multiple-counters
Open
Support for per-field limits#15JamesSkemp wants to merge 1 commit intodarrentaytay:masterfrom JamesSkemp:multiple-counters
JamesSkemp wants to merge 1 commit intodarrentaytay:masterfrom
JamesSkemp:multiple-counters
Conversation
If adding a counter to multiple fields, with each having a different maxlength, the limit on the last counter on the page will be used for all other counters. This stores the limit on the respective counter instead.
Author
|
This is my first attempt at a pull request, so please be gentle :) This is related to #10. While it seemed to work, once I started typing into a field I found that the maximum length had been set to whatever was set on the last field on the page (options.limit is updated for each field, with the last having the final say). This stores the length on the counter element itself instead, which is then checked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If adding a counter to multiple fields, with each having a different maxlength, the limit on the last counter on the page will be used for all other counters. This stores the limit on the respective counter instead.