additional memory allocation checks #18114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfbrown
added
the
scope: codebase
|
I would prefer to always use dt_print() instead of fprintf() ... |
|
Those fprintf() calls are inside an #ifdef STANDALONE, and would require including darktable.h (and thus most of darktable's headers, plus linking in darktable.c and everything it pulls in) to replace them with dt_print calls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this has been sitting around for a while....
Could be tagged bugfix and slotted in for 5.0.1 although it isn't fixing any reported bugs. Won't fight for that, though.
The checks in pdf.c, printprof.c, and utility.c are the ones most likely to be triggered by OOM since they are allocating full images.