fix major performance regression in haze removal #18113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfbrown
added
bugfix
TurboGit
reviewed
Dec 30, 2024
TurboGit
pushed a commit
that referenced
this pull request
Dec 31, 2024
* fix partitioning in quick_select non-compat mode
|
Merged in master and 5.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While most images still worked very quickly, a completely wrong partitioning function resulted in the new non-compatibility quick select occasionally taking extraordinary amounts of time (I had one RPU image take 2.5 hours and killed another after 13 hours). The old compaitibility-mode code wasn't affected by the broken partitioning since it assumed the partition would always be exactly 50/50....
New integration test to verify correct results: darktable-org/darktable-tests#38
Fixes #18081