Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrast equalizer should be after sigmoid/filmic #18040

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blitzgneisserin
Copy link
Contributor

else it creates artefacts, this is a display referred tool that works in lab

else it creates artefacts, this is a display referred tool that works in lab
@jenshannoschwalm
Copy link
Collaborator

I personally don't think this is a good idea. Technically there is much more involved. If you really wanna go into this and would want others to test you could see how things could be done in #17780 and #17791 ...

@blitzgneisserin
Copy link
Contributor Author

Do I understand this correctly that you agree that the module is in the wrong place but it's complicated to change it?

@jenshannoschwalm
Copy link
Collaborator

Nope, not at all i meant it's too complicated - was just hinting there is more involved than the one-liner :-)

Not thinking it's a good idea was about the implications of changing the order. Working in lab space is something completely different than working in "display referred space" as we do after sigmoid or filmic. I am absolutely unsure if we just have different (or even more) artifacts by doing as you propose. So if you provide something just-working i would be willing to test or if you can at least provide samples showing clearly improved results.

@blitzgneisserin
Copy link
Contributor Author

blitzgneisserin commented Dec 22, 2024

contrast equalizer before sigmoid:
_C214415_01

contrast eqalizer after sigmoid:
_C214415_02

to be honest, it is barely noticeable but in after the effect is stronger, while the haloing is better, in before it's the other way round.
probably it's better visible if I exaggerate the effect.

@TurboGit TurboGit added the controversial this raises concerns, don't move on the technical work before reaching a consensus label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controversial this raises concerns, don't move on the technical work before reaching a consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants