Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[export]: unregister signal handler on cleanup #18025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[export]: unregister signal handler on cleanup #18025

wants to merge 1 commit into from

Conversation

zisoft
Copy link
Collaborator

@zisoft zisoft commented Dec 17, 2024

The signal handler for DT_SIGNAL_IMAGEIO_STORAGE_EXPORT_ENABLE in the export module is not unregistered on cleanup.

@zisoft
unregister signal handler on cleanup
2e45883 
The signal handler for `DT_SIGNAL_IMAGEIO_STORAGE_EXPORT_ENABLE` in the
export module is not unregistered on cleanup.
@TurboGit TurboGit added this to the 5.0.1 milestone Dec 17, 2024
@dterrahe
Copy link
Member

alternatively 9a20e63

@jenshannoschwalm
Copy link
Collaborator

@zisoft there are certainly more signals/modules in darktable.lib involved here ... so it might be a better / more complete solution to take the full bunch from 9a20e63

@zisoft
Copy link
Collaborator Author

zisoft commented Dec 23, 2024 •
edited
Loading

Agreed. So if @TurboGit merges 9a20e63 this PR can be closed.

@TurboGit TurboGit self-requested a review December 23, 2024 16:49
@jenshannoschwalm
Copy link
Collaborator

alternatively 9a20e63

lens and import don't rebase cleanly ...

@dterrahe
Copy link
Member

8edeb69 / https://github.com/dterrahe/darktable/tree/autodissignal

@jenshannoschwalm
Copy link
Collaborator

Very nice. Spurious signal crashing with current "closing in the dark" pr have gone btw when using this commit .

@TurboGit TurboGit modified the milestones: 5.0.1, 5.2 Dec 29, 2024
@TurboGit
Copy link
Member

Moving to 5.2 and in fact 8edeb69 will be merged and this closed.

@TurboGit TurboGit added bug: won't fix the bug needs a fix outside of the scope of darktable, at a theoretical level priority: high core features are broken and not usable at all, software crashes difficulty: hard big changes across different parts of the code base labels Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit Awaiting requested review from TurboGit

Assignees
No one assigned
Labels
bug: won't fix the bug needs a fix outside of the scope of darktable, at a theoretical level difficulty: hard big changes across different parts of the code base priority: high core features are broken and not usable at all, software crashes
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@zisoft @dterrahe @jenshannoschwalm @TurboGit