Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gtk_widget_set_app_paintable. #15908

Conversation

Christian-Kr
Copy link

Hello to everyone,

as part of the migration to gtk4 remove the method gtk_widget_set_app_paintable. The gtk3 documentation says, that most widgets already ignore this setting and it is only helpful if you want to change the background of some widgets.

After testing the change, I can't see any widget background that might have changed. Maybe it has already been changed, or I just missed a change.

Please test the change and if everything is still working, accept the PR.

Thank you in advance.
Greetings

@TurboGit
Copy link
Member

@Christian-Kr : Just a note that we are in the process of releasing the 4.6 release. So your work will be reviewed a bit later.

Nice to see some work toward Gtk4, do you have a clear view of the amount of work needed? TIA.

@Christian-Kr
Copy link
Author

Hello @TurboGit,

don't worry. I had a clear view for other applications, but for darktable, I just wanted to start coding. So no, I don't know the amount of work.

Greetings

@elstoc
Copy link
Contributor

elstoc commented Dec 19, 2023

Could we maybe have a new label we can use for Gtk4 preparatory work. Even better if we could have an issue to track some sort of to-do list, so others can assist with the work.

There will almost certainly be some more complicated bits of functionality to change so separate issues for those would be good as well (as-and-when you find that sort of thing).

@Christian-Kr
Copy link
Author

Could we maybe have a new label we can use for Gtk4 preparatory work. Even better if we could have an issue to track some sort of to-do list, so others can assist with the work.

There will almost certainly be some more complicated bits of functionality to change so separate issues for those would be good as well (as-and-when you find that sort of thing).

#15920

Copy link

This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@Christian-Kr
Copy link
Author

Reopen with conflict resolved and rebase.

Copy link

github-actions bot commented Aug 3, 2024

This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@Christian-Kr
Copy link
Author

Hello to everyone,

how do we want to go on with this small one? Do we want to pull it to master or to another branch or cancel it totally? I am just asking because I want to clean few things up.

Thx in advance :-)
Greetings

@Christian-Kr
Copy link
Author

Christian-Kr commented Nov 23, 2024

In order to make the whole migration inside a single branch, close this one and merge the branch Christian-Kr:krippendorf/gtk4_prepare_002 into Christian-Kr:krippendorf/gtk4.

This PR is not needed anymore.

Greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants